From owner-freebsd-desktop@freebsd.org Fri Feb 26 19:31:58 2021 Return-Path: Delivered-To: freebsd-desktop@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B3D9A54C6AB for ; Fri, 26 Feb 2021 19:31:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DnKXt4W8rz4mj4 for ; Fri, 26 Feb 2021 19:31:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9AC8C54C735; Fri, 26 Feb 2021 19:31:58 +0000 (UTC) Delivered-To: desktop@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A8FE54C985 for ; Fri, 26 Feb 2021 19:31:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnKXt3vXcz4mkg for ; Fri, 26 Feb 2021 19:31:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7914D10437 for ; Fri, 26 Feb 2021 19:31:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11QJVwoa053228 for ; Fri, 26 Feb 2021 19:31:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11QJVw12053227 for desktop@FreeBSD.org; Fri, 26 Feb 2021 19:31:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 253602] devel/glib20: Local patch to glib20 uses a broken and unstable fdwalk implementation Date: Fri, 26 Feb 2021 19:31:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-desktop@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Using and improving FreeBSD on the desktop List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 19:31:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253602 --- Comment #4 from commit-hook@FreeBSD.org --- A commit references this bug: Author: jhb Date: Fri Feb 26 19:31:05 UTC 2021 New revision: 566632 URL: https://svnweb.freebsd.org/changeset/ports/566632 Log: Use kinfo_getfile() to implement fdwalk(). Previously, the kern.file sysctl (which queries the global file table) was queried and the results saved in an on-stack buffer. With a sufficiently active system the sysctl's output could overflow the stack's available space. Instead, switch to kinfo_getfile() from libutil. This uses a sysctl which queries only the open files for the current process, and it uses heap space instead of the stack to store the sysctl output. PR: 253602 Submitted by: ps (build glue patches) Reported by: ps Reviewed by: bapt MFH: 2021Q1 Differential Revision: https://reviews.freebsd.org/D28904 Changes: head/devel/glib20/Makefile head/devel/glib20/files/patch-glib_gspawn.c head/devel/glib20/files/patch-glib_meson.build head/devel/glib20/files/patch-meson.build --=20 You are receiving this mail because: You are the assignee for the bug.=