Date: Tue, 12 Dec 2006 08:49:53 +0100 (CET) From: Nick Hibma <nick@van-laarhoven.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: Slight interface change on the watchdog fido Message-ID: <20061212084536.M1171@localhost> In-Reply-To: <200612111608.06677.jhb@freebsd.org> References: <20061210110419.H42195@localhost> <200612111608.06677.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> It would be nice to not lose the comments. Might also be nice to reduce the
> diff (so it doesn't have to reindent everything) by just adding a simple test
> after masking off WD_INTERVAL like so:
>
> if (cmd == 0 || cmd >= 64) {
> ipmi_set_watchdog(sc, 0);
> return;
> }
The code path pretty much requires the
if (cmd > 0 && valid(cmd) {
wd(set);
*error = 0;
} else if (wd(active)) {
wd(disable);
}
due to the way *error was defined.
I've added back the comments that were more than trivial.
Nick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061212084536.M1171>