From owner-freebsd-bugs@freebsd.org Mon Mar 14 14:34:04 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAD28AD0354 for ; Mon, 14 Mar 2016 14:34:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C1596DD8 for ; Mon, 14 Mar 2016 14:34:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u2EEY4Kr029179 for ; Mon, 14 Mar 2016 14:34:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 207975] mac_bsdextended allows renaming and moving, when it should not (after commit 272130) Date: Mon, 14 Mar 2016 14:34:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cejkar@fit.vutbr.cz X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2016 14:34:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207975 Bug ID: 207975 Summary: mac_bsdextended allows renaming and moving, when it should not (after commit 272130) Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: cejkar@fit.vutbr.cz After commit 272130 (https://lists.freebsd.org/pipermail/svn-src-head/2014-September/062990.htm= l), mac_bsdextended allows renaming and moving, when it should not. Unfortunate= ly, the change is rather old, so the same problem is in 10-STABLE already too. Quick test (change "user" to your favorite login in you system): # kldload mac_bsdextended # ugidfw add subject uid user object type l mode rs # su - user $ ln -s src dst $ rm -v dst rm: dst: Permission denied # correct $ mv -v dst dst2 dst -> dst2 # incorrect, it should be permission den= ied $ exit # You can look into sys/security/mac_bsdextended/ugidfw_vnode.c, functions ugidfw_vnode_check_rename_from() and ugidfw_vnode_check_unlink() - the codes are the same, but behavior is different. Before 272130, it really worked an= d mv was not possible, so probably change 272130 changed behavior, so that ugidfw_vnode_check_rename_from() is not called for rename operation anymore? --=20 You are receiving this mail because: You are the assignee for the bug.=