Date: Wed, 16 Apr 2008 16:53:55 +0200 From: Pietro Cerutti <gahr@FreeBSD.org> To: Ganael LAPLANCHE <ganael.laplanche@martymac.com> Cc: ports@freebsd.org, Anatoly Borodin <anatoly.borodin@gmail.com> Subject: Re: CFT: devel/directfb update to 1.1.1 Message-ID: <48061303.6040001@FreeBSD.org> In-Reply-To: <20080416134523.M15457@martymac.com> References: <48053F56.4090404@FreeBSD.org> <20080416064154.M28876@martymac.com> <4805BB13.1050007@FreeBSD.org> <20080416094711.M99470@martymac.com> <e1e1b0290804160601w5dce2c38xfec27bffa15271ae@mail.gmail.com> <20080416134523.M15457@martymac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Ganael LAPLANCHE wrote:
| On Wed, 16 Apr 2008 16:01:43 +0300, Anatoly Borodin wrote
| It produces the same error as previously reported : "No system
found!". Very
| strange, but applying those two patches allows the libs to be found
and mplayer
| to (nearly) start :
|
| --- lib/direct/interface.c.orig 2008-04-12 13:25:57.542006795 +0200
| +++ lib/direct/interface.c 2008-04-12 13:26:27.732927708 +0200
| @@ -164,7 +164,7 @@
| /*
| * Iterate directory.
| */
| - while (readdir_r( dir, &tmp, &entry ) == 0 && entry) {
| + while (entry = readdir( dir )) {
| void *handle = NULL;
| char buf[4096];
|
| --- lib/direct/modules.c.orig 2008-04-12 13:25:45.166038341 +0200
| +++ lib/direct/modules.c 2008-04-12 13:27:56.054698492 +0200
| @@ -158,7 +158,7 @@
| return 0;
| }
|
| - while (readdir_r( dir, &tmp, &entry ) == 0 && entry) {
| + while (entry = readdir( dir )) {
| void *handle;
| DirectModuleEntry *module;
| int entry_len = strlen(entry->d_name);
Actually, there is a bug in those two functions. What about this one?
- --- lib/direct/modules.c.orig 2008-04-16 16:51:42.000000000 +0200
+++ lib/direct/modules.c 2008-04-16 16:51:53.000000000 +0200
@@ -158,7 +158,7 @@
~ return 0;
~ }
- - while (readdir_r( dir, &tmp, &entry ) == 0 && entry) {
+ while (!readdir_r( dir, &tmp, &entry ) == 0 && entry) {
~ void *handle;
~ DirectModuleEntry *module;
~ int entry_len = strlen(entry->d_name);
- --- lib/direct/interface.c.orig 2008-04-16 16:49:47.000000000 +0200
+++ lib/direct/interface.c 2008-04-16 16:50:52.000000000 +0200
@@ -164,7 +164,7 @@
~ /*
~ * Iterate directory.
~ */
- - while (readdir_r( dir, &tmp, &entry ) == 0 && entry) {
+ while (!readdir_r( dir, &tmp, &entry ) && entry) {
~ void *handle = NULL;
~ char buf[4096];
| Best regards,
Best,
| Ganaël LAPLANCHE
- --
Pietro Cerutti
gahr@FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (FreeBSD)
iEYEAREKAAYFAkgGEwIACgkQwMJqmJVx947LvACgyUDzENJvTKcS+ExOtmrRLF90
l1YAoINBx7I/Qo8rcvELwRa1bi4d/aiO
=KGAo
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48061303.6040001>