From owner-freebsd-current Wed Sep 13 22:36:54 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id WAA20041 for current-outgoing; Wed, 13 Sep 1995 22:36:54 -0700 Received: from GndRsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.241]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id WAA20035 for ; Wed, 13 Sep 1995 22:36:51 -0700 Received: (from rgrimes@localhost) by GndRsh.aac.dev.com (8.6.12/8.6.12) id WAA06494; Wed, 13 Sep 1995 22:35:18 -0700 From: "Rodney W. Grimes" Message-Id: <199509140535.WAA06494@GndRsh.aac.dev.com> Subject: Re: -stable: *** Error code ONLY one To: bde@zeta.org.au (Bruce Evans) Date: Wed, 13 Sep 1995 22:35:18 -0700 (PDT) Cc: jmb@kryten.atinc.com, current@freebsd.org In-Reply-To: <199509140502.PAA09329@godzilla.zeta.org.au> from "Bruce Evans" at Sep 14, 95 03:02:29 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 920 Sender: current-owner@freebsd.org Precedence: bulk > > >> beforeinstall: > >> + rm -f ${DESTDIR}/etc/rmt > >> -ln -s ${BINDIR}/rmt ${DESTDIR}/etc/rmt > >> > >> .include > >> > > >Correct method: > > > if [ ! -e ${DESTDIR}/etc/rmt]; then \ > > ln -s ${BINDIR}/rmt ${DESTDIR}/etc/rmt \ > > fi > > >It is not nice for make world to touch things in /etc, no matter what > >it is. The unsilent ignoreing of the error above was a quick hack > >by some one who did not bother to do it correctly. > > Really correct method: > > # -ln -s ${BINDIR}/rmt ${DESTDIR}/etc/rmt > > `make install' in /usr/src doesn't install /etc/rc so why should it > install /etc/rmt? Agreed, the above should be put in src/etc/Makefile and be a forced unconditional install of ${DESTDIR}/etc/rmt. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD