From owner-svn-src-all@freebsd.org Fri Mar 10 20:12:07 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 06F28D06AB4 for ; Fri, 10 Mar 2017 20:12:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB7F51468 for ; Fri, 10 Mar 2017 20:12:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x242.google.com with SMTP id f203so496533itf.2 for ; Fri, 10 Mar 2017 12:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=RieahIiCDLzmC02WXUXO9rqht5tS/PWrIs3wguaKgLo=; b=ShfKnHOd2sj/hUMEdWv61xmDdZaawDqoNwISMqAw/HfFJlIeVdSbHY011Amei49GU5 Kl6PARs17vQZPgPJT5OZHzNuC9MP7V3TgAy21pnzHMH429BxFc0UWDxi4WZImU5oOqOT vfoXHSglBM54HbQkDDWVpZcmbGbgk2LxPTGeoFw3SYHXQLsN2nqvuH9ooyGI4IPojty4 GrCwFJ9TEanl6PIpbFIEeSVP3cmKgIGKiL6TGOjHvHjiRO/L3BgRMVIRnELFt5j1z/x0 8VW+qC+jtPeRTLKng4hZnbRW1it6E15l+oB7rfZ6/78RkjUCabokpFSCeLApmrWlqBaJ TeVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=RieahIiCDLzmC02WXUXO9rqht5tS/PWrIs3wguaKgLo=; b=ETiz0s81NK6THGMtoagbBCn9/IeRTu9vmJfsmEJi9AaOJvA1oikoffXbLyit1XLi1E SGKiOSh3AX3ce44Ndg5qJyNOoW32NQezzwackMZYSr+ey7Ze5wdzw8yQaKgrkKKNpk22 Jo5axy35zVZ3mKkKj7VBnW7CrnCvxsqZDqxFPXMObA0EK6UNjUXAwuL7A3ycH6MyfR2v +0VG9dTEAgjw8CCGtv5pv9SdRGguPwLaNfNpA2KX5kckfBhg4oq60QehFkEQseaN8xtD DjoCQlXzHzQSzIsnkOliV4TmrUrr6+TB+cqRmd/8Ct9h8P6OFpRV+GntxaltTg8EHHgV qzoA== X-Gm-Message-State: AFeK/H2ZVCc0+LYmJPAL19Pz3Fz3uyVSfvLdnpcv2td1IlIGDSg/QA8BlzR2LkKUQRQo64fiIqteYH2/IGzKAQ== X-Received: by 10.36.90.194 with SMTP id v185mr789654ita.85.1489176726076; Fri, 10 Mar 2017 12:12:06 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Fri, 10 Mar 2017 12:12:05 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: References: <201701100323.v0A3NMAI045868@repo.freebsd.org> <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com> From: Warner Losh Date: Fri, 10 Mar 2017 13:12:05 -0700 X-Google-Sender-Auth: HYSYA8syjKEbv58y81btsYYKUvA Message-ID: Subject: Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf To: Adrian Chadd Cc: Navdeep Parhar , Ryan Stone , Sean Bruno , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 20:12:07 -0000 On Fri, Mar 10, 2017 at 1:10 PM, Adrian Chadd wrot= e: > On 10 March 2017 at 12:09, Warner Losh wrote: >> It's already in loader.hints. The bug is that ifconfig doesn't use a >> library (which others can use) to find the module by name, but rather >> assumes a particular filename -> module name mapping. > > Sounds like a GSoC project. :-) Done properly, it could also solve the auto-loading of drivers issue :) Many of the pieces are there, though marking pci drivers would need to be done in earnest. Warner > > -adrian > >> Warner >> >> On Fri, Mar 10, 2017 at 1:07 PM, Adrian Chadd w= rote: >>> s/ifconfig/put-it-in-a-config-file-in-share-so-we-dont-have-to-patch-if= config-every-time-we-change-this-kthxbai/g >>> >>> >>> -adrian >>> >>> >>> On 10 March 2017 at 11:12, Navdeep Parhar wrote: >>>> On Fri, Mar 10, 2017 at 10:41 AM, Ryan Stone wrote= : >>>>> There's also the issue that running "ifconfig igb0 blah" during start= up will >>>>> cause if_igb to be automatically loaded by ifconfig. >>>>> >>>>> I guess we could add a dummy if_igb.ko that just has a dependency on >>>>> if_em.ko >>>> >>>> I do similar stuff in cxgbe (if_cxl.ko and if_cc.ko exist solely to >>>> drag in if_cxgbe.ko as a dependency). In hindsight I wish I'd just >>>> added a list of ifnet names -> kld map to ifconfig instead. It would >>>> have been an ugly hack but much simpler. >>>> >>>> Regards, >>>> Navdeep >>>> >>>>> >>>>> On Fri, Mar 10, 2017 at 1:13 PM, Warner Losh wrote: >>>>>> >>>>>> On Fri, Mar 10, 2017 at 11:06 AM, Sean Bruno wr= ote: >>>>>> > >>>>>> > >>>>>> > On 02/15/17 03:06, Roger Pau Monn=C3=A9 wrote: >>>>>> >> On Tue, Jan 10, 2017 at 03:23:22AM +0000, Sean Bruno wrote: >>>>>> >>> Author: sbruno >>>>>> >>> Date: Tue Jan 10 03:23:22 2017 >>>>>> >>> New Revision: 311849 >>>>>> >>> URL: https://svnweb.freebsd.org/changeset/base/311849 >>>>>> >>> >>>>>> >>> Log: >>>>>> >>> Migrate e1000 to the IFLIB framework: >>>>>> >>> - em(4) igb(4) and lem(4) >>>>>> >>> - deprecate the igb device from kernel configurations >>>>>> >>> - create a symbolic link in /boot/kernel from if_em.ko to if_i= gb.ko >>>>>> >> >>>>>> >> This linking causes mfsBSD to choke when building an image from H= EAD. >>>>>> >> It tries >>>>>> >> to issue the following command: >>>>>> >> >>>>>> >> ${_v}${CP} -rp ${_BOOTDIR}/kernel ${WRKDIR}/disk/boot >>>>>> >> >>>>>> >> Which fails when finding the symbol link. I can send a patch to c= hange >>>>>> >> that to >>>>>> >> -Rp, which would work fine, but wouldn't it be better to either >>>>>> >> completely >>>>>> >> remove if_igb.ko, or simply copy if_em.ko to if_igb.ko? >>>>>> >> >>>>>> >> I'm wondering if for example anyone strips down it's /boot/kernel= / >>>>>> >> manually, by >>>>>> >> removing unused modules, and what would happen if if_em.ko is rem= oved >>>>>> >> but not >>>>>> >> if_igb.ko. >>>>>> >> >>>>>> >> Roger. >>>>>> >> >>>>>> >> >>>>>> > >>>>>> > Well, this was my naive attempt to make upgrades for users to be >>>>>> > non-eventful in the event they have "if_igb_load=3DYES" in their >>>>>> > loader.conf instead of having it built into their kernel. >>>>>> > >>>>>> > If the -Rp works, I'll add that instead. >>>>>> >>>>>> The module name is encoded in the module itself. The boot loader loo= ks >>>>>> it up to see which module to load. Maybe there's a way to fix it so >>>>>> both load from one file? >>>>>> >>>>>> Warner >>>>>> >>>>> >>>>