From nobody Fri Jun 17 19:37:50 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8E58085AC4C; Fri, 17 Jun 2022 19:37:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LPq801BcJz3Ppn; Fri, 17 Jun 2022 19:37:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655494672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O5Ijnwha/eT2RTgkssZkagOjHVMdG0Ya9hPXv6usGD0=; b=SGotEzEY0j2GGiW+joqVZ+7PLZrKGJvgqg58Nq6Yh/uFz4rLLuREps6gaOZV0QmwNHjMs0 bv3U4A1zGTglR7iupHnhgb2r1rpeE9XlVI1MQJtS5NpKP8tlrSp/oGHJYmwFJ3G40cj9Ad ry+qL2FQ9RS8Tk2gWQofNty/6pHJtSSgxgPhYoUAsXN9X28U8H9F/yfHU09Xe7Lnzl5oCa 7/cdOGcZo6wFUl+NQVqdz50U/23ftclZ7LBKb7py5swxIpID8sR9UB7NN3OFDJP8X5VAX5 uV0opVbv5gtbslVdgpXo3NEBb7mEoU8uTmgdI8sZ8qHWrVoXQ5LUvVW+K9pHjw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BEA04257D3; Fri, 17 Jun 2022 19:37:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 25HJboj9013893; Fri, 17 Jun 2022 19:37:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 25HJbop9013892; Fri, 17 Jun 2022 19:37:50 GMT (envelope-from git) Date: Fri, 17 Jun 2022 19:37:50 GMT Message-Id: <202206171937.25HJbop9013892@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dmitry Chagin Subject: git: fdc3cb323348 - stable/13 - linux(4): Add a comment about wait/requeue pi operations. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: fdc3cb32334865bea072e66ed103ecf9390091ca Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655494672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O5Ijnwha/eT2RTgkssZkagOjHVMdG0Ya9hPXv6usGD0=; b=FrBgfPHeuyDWzqsM5lKEWWjVBMVzfKQbHfbWS8qkjZe2S6vNEN+ZujxBhlTHo/RkxdT+gT nUqW7Xg4+CT7G4aH3uwIrck8QY26AGuH0sFnD6Q/FUYFWvk3f9rei9qq++jHgPgvrwh6Xx U7ECI3MEIu2GXqyemILaogJ5tbgKTqnHyH5+1SXkRmBKb0TU2FTNHHWR0J7xBSvAjcGiYF hTIW/YZ+F8LO4mzNpJMBTkW2qKcH5MD7V3M5TNVDNTvmpvEZeCRb/zAzdqj3/ZbpW7Snq8 v4WPQ37sTUYvQHKTGd16+LZhflO3Lbwxq0EYmduckpjwAxNoi3qPn/3q9fPn8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655494672; a=rsa-sha256; cv=none; b=Od0c/tjxpVYdOxgFLYsE6xfcKpIkmA4Ffz8E5+7VMsYn0/17dSSb8fFWVfpR4Ufdzvfp7z 1y7sU5RHcwE86qtXw12VENPwa3KyqiQ39CEqk8dWdAtMqmWhUjPdSCvv+7xDgMzhIpjbS5 hiKav6aTIVEAVHyZoo8b9/U9Mzf5vGi1xIiWAxaVGQHcmxyoMtj+7wQJL+5GgBYG+4kqis GiYPL02U3SHZmhkXrP4KqTcisY1XZVk5JB5alOH7LRd200SumaY/30Kvo0v69AvkkF1EUa lkp4EnW/7mVnohun7Vj0DAAQZn+Z4oqjHAWm1Fvh+lGYjlMf2TAR7LX4/EbMqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=fdc3cb32334865bea072e66ed103ecf9390091ca commit fdc3cb32334865bea072e66ed103ecf9390091ca Author: Dmitry Chagin AuthorDate: 2021-07-29 09:55:59 +0000 Commit: Dmitry Chagin CommitDate: 2022-06-17 19:33:25 +0000 linux(4): Add a comment about wait/requeue pi operations. MFC after: 2 weeks (cherry picked from commit d90df8ac1324d731f8423b5501158ee870fbd5ba) --- sys/compat/linux/linux_futex.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sys/compat/linux/linux_futex.c b/sys/compat/linux/linux_futex.c index 5f18c93b0988..edf059f74272 100644 --- a/sys/compat/linux/linux_futex.c +++ b/sys/compat/linux/linux_futex.c @@ -314,6 +314,18 @@ linux_futex(struct thread *td, struct linux_futex_args *args) return (linux_futex_lock_pi(td, true, args)); + /* + * Current implementation of FUTEX_WAIT_REQUEUE_PI and FUTEX_CMP_REQUEUE_PI + * can't be used anymore to implement conditional variables. + * A detailed explanation can be found here: + * + * https://sourceware.org/bugzilla/show_bug.cgi?id=13165 + * and here http://austingroupbugs.net/view.php?id=609 + * + * And since commit + * https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ed19993b5b0d05d62cc883571519a67dae481a14 + * glibc does not uses it. + */ case LINUX_FUTEX_WAIT_REQUEUE_PI: /* not yet implemented */ pem = pem_find(td->td_proc);