From owner-svn-src-all@freebsd.org Sun Oct 13 02:10:56 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8FEFD016E; Sun, 13 Oct 2019 02:10:56 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46rQCN26pFz4G4Y; Sun, 13 Oct 2019 02:10:55 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x9D2AppA097895; Sat, 12 Oct 2019 19:10:51 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x9D2AokR097894; Sat, 12 Oct 2019 19:10:50 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201910130210.x9D2AokR097894@gndrsh.dnsmgr.net> Subject: Re: svn commit: r353456 - head/usr.sbin/pciconf In-Reply-To: <201910122227.x9CMRvPK044042@repo.freebsd.org> To: Scott Long Date: Sat, 12 Oct 2019 19:10:50 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 46rQCN26pFz4G4Y X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Oct 2019 02:10:56 -0000 > Author: scottl > Date: Sat Oct 12 22:27:57 2019 > New Revision: 353456 > URL: https://svnweb.freebsd.org/changeset/base/353456 > > Log: > Change from the non-standard nomenclature of "chip" and "card" to the > standard nomenclature of "device" and "vendor" with the "sub" variants. > This changes the printed format, so anything that scrapes and parses > this will need to be adapted. No compatibility shims are provided, > but this will not be MFC'd. I can not "adapt" google easily, seaching for these strings are often very usefull in finding stuff like bug reports and ohers with similiar issues. I am not sure the gain of this is positive over the loss of that. > > Reviewed by: jhb, emaste, gtetlow > Approved by: jhb, emaste, gtetlow > > Modified: > head/usr.sbin/pciconf/pciconf.c > > Modified: head/usr.sbin/pciconf/pciconf.c > ============================================================================== > --- head/usr.sbin/pciconf/pciconf.c Sat Oct 12 20:53:40 2019 (r353455) > +++ head/usr.sbin/pciconf/pciconf.c Sat Oct 12 22:27:57 2019 (r353456) > @@ -261,8 +261,8 @@ list_devs(const char *name, int verbose, int bars, int > return; > } > for (p = conf; p < &conf[pc.num_matches]; p++) { > - printf("%s%d@pci%d:%d:%d:%d:\tclass=0x%06x card=0x%08x " > - "chip=0x%08x rev=0x%02x hdr=0x%02x\n", > + printf("%s%d@pci%d:%d:%d:%d:\tclass=0x%06x subvendor=0x%04x subdevice=0x%04x " > + "vendor=0x%04x device=0x%04x rev=0x%02x hdr=0x%02x\n", > *p->pd_name ? p->pd_name : > "none", > *p->pd_name ? (int)p->pd_unit : > @@ -270,8 +270,8 @@ list_devs(const char *name, int verbose, int bars, int > p->pc_sel.pc_bus, p->pc_sel.pc_dev, > p->pc_sel.pc_func, (p->pc_class << 16) | > (p->pc_subclass << 8) | p->pc_progif, > - (p->pc_subdevice << 16) | p->pc_subvendor, > - (p->pc_device << 16) | p->pc_vendor, > + p->pc_subdevice, p->pc_subvendor, > + p->pc_device, p->pc_vendor, > p->pc_revid, p->pc_hdr); > if (verbose) > list_verbose(p); > -- Rod Grimes rgrimes@freebsd.org