From owner-freebsd-bugs  Sat Sep  2 21:10: 7 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 77B9A37B42C
	for <freebsd-bugs@FreeBSD.org>; Sat,  2 Sep 2000 21:10:02 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id VAA20677;
	Sat, 2 Sep 2000 21:10:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefour.acs.rpi.edu (freefour.acs.rpi.edu [128.113.24.91])
	by hub.freebsd.org (Postfix) with ESMTP id 9A67837B424
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  2 Sep 2000 21:02:40 -0700 (PDT)
Received: (from gad@localhost)
	by freefour.acs.rpi.edu (8.9.3/8.9.3) id AAA73736;
	Sun, 3 Sep 2000 00:02:39 -0400 (EDT)
	(envelope-from gad)
Message-Id: <200009030402.AAA73736@freefour.acs.rpi.edu>
Date: Sun, 3 Sep 2000 00:02:39 -0400 (EDT)
From: Garance A Drosehn <gad@freefour.acs.rpi.edu>
Reply-To: gad@eclipse.acs.rpi.edu
To: FreeBSD-gnats-submit@freebsd.org
Cc: gad@eclipse.acs.rpi.edu
X-Send-Pr-Version: 3.2
Subject: bin/21006: Minor fix to 'lprm' message
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         21006
>Category:       bin
>Synopsis:       Minor fix to 'lprm' message
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 02 21:10:02 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Garance A Drosehn
>Release:        FreeBSD 4-stable and 5-current
>Organization:
RPI ; Troy, NY
>Environment:

	After some recent changes to common_source/rmjob, a cosmetic
	error exists in the message returned from 'lprm'.
	You will only notice the problem if you have a 'client' sending
	jobs for some print-queue to a freebsd machine acting as a 'server'.

>Description:

	The 'client' machine should see a message of the form:
	    <servername>: <filename> dequeued
	and instead sees:
	    <servername>: <servername>: <filename> dequeued
	The problem being that the printing of the server name is done
	in the do_unlink routine, and in one place it is also done just
	before calling do_unlink.

>How-To-Repeat:

	Send some jobs from a client machine to a server machine, and
	then use lprm to remove the jobs...

>Fix:
	
	Here's a simple fix:

--- common_source/rmjob.c.orig	Fri Aug 27 21:16:48 1999
+++ common_source/rmjob.c	Sat Sep  2 19:36:25 2000
@@ -211,8 +211,6 @@
 		case 'U':  /* unlink associated files */
 			if (strchr(line+1, '/') || strncmp(line+1, "df", 2))
 				break;
-			if (from != host)
-				printf("%s: ", host);
 			do_unlink(line+1);
 		}
 	}


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message