Date: Sun, 05 Dec 2004 15:27:18 -0700 (MST) From: Warner Losh <imp@harmony.village.org> To: phk@phk.freebsd.dk Cc: nate@root.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c Message-ID: <20041205.152718.41673284.imp@harmony.village.org> In-Reply-To: <68311.1102285179@critter.freebsd.dk> References: <41B388C6.5090409@root.org> <68311.1102285179@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> Subject: Re: cvs commit: src/sys/dev/acpica acpi.c Date: Sun, 05 Dec 2004 23:19:39 +0100 > In message <41B388C6.5090409@root.org>, Nate Lawson writes: > >M. Warner Losh wrote: > >> In message: <200412050135.iB51ZJJl040909@repoman.freebsd.org> > >> Nate Lawson <njl@FreeBSD.org> writes: > >> : If we are resuming non-MPSAFE drivers, they need Giant held for them. > >> > >> Generally, when walking the device tree, one must have Giant. I've > >> been meaning to add asserts for this in the tree... I think that we > >> have enough things giant is pushed out of that it is time... > > > >I'd like that. I think the GIANT_REQUIRED asserts should go in the > >root_bus suspend/resume/shutdown methods, not in acpi. This will cover > >everyone unless a driver drops Giant and doesn't reacquire it (unlikely). > > In Geom I assert after I call driver methods, just to catch that case > as well. Excellent idea... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041205.152718.41673284.imp>