From owner-freebsd-audit Wed Mar 20 10:25:43 2002 Delivered-To: freebsd-audit@freebsd.org Received: from bremen.shuttle.de (bremen.shuttle.de [194.95.249.251]) by hub.freebsd.org (Postfix) with ESMTP id C299637B400; Wed, 20 Mar 2002 10:25:40 -0800 (PST) Received: from bremen.shuttle.de (localhost [127.0.0.1]) by bremen.shuttle.de (Postfix) with ESMTP id 3863617D50; Wed, 20 Mar 2002 19:25:30 +0100 (CET) Received: (from uucp@localhost) by bremen.shuttle.de (8.12.1/8.12.1/Debian -5) with UUCP id g2KIPUix014059; Wed, 20 Mar 2002 19:25:30 +0100 Received: (from schweikh@localhost) by hal9000.schweikhardt.net (8.12.2/8.11.6) id g2KIQPqp002267; Wed, 20 Mar 2002 19:26:25 +0100 (CET) (envelope-from schweikh) Date: Wed, 20 Mar 2002 19:26:24 +0100 From: Jens Schweikhardt To: Garance A Drosihn Cc: freebsd-audit@FreeBSD.ORG, joerg@FreeBSD.ORG Subject: Re: crontab changes for PR bin/22612; please comment Message-ID: <20020320192624.A1258@schweikhardt.net> References: <20020318130904.A3869@schweikhardt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from drosih@rpi.edu on Mon, Mar 18, 2002 at 04:08:04PM -0500 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Mar 18, 2002 at 04:08:04PM -0500, Garance A Drosihn wrote: # At 1:09 PM +0100 3/18/02, Jens Schweikhardt wrote: # >hello, world\n # > # >please comment on this patch (slightly different from the # >one in the PR # >http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/22612) # > # >Currently, checking for modification of the tmp file just # >looks at the mtime and gives a false "no modification" if # >the edit took less than 1 second. This is solved by simply # >comparing the whole struct stat. ... # Stupid brain-dead alternative fix: # Create the file. stat the file. sleep a second. # *Then* open the file in the user's editor. Any # change that they make will have to have been done # more than a second later. Hmm. What about completely removing the test whether the tmp file was modified? Just try to install the crontab, no matter what. Or is there a reason why crontab files must not be installed if they havn't changed? Regards, Jens -- Jens Schweikhardt http://www.schweikhardt.net/ SIGSIG -- signature too long (core dumped) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message