From owner-cvs-src@FreeBSD.ORG Tue May 4 20:31:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A48E16A4CE; Tue, 4 May 2004 20:31:06 -0700 (PDT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31F5343D41; Tue, 4 May 2004 20:31:06 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i453UcVv074871; Tue, 4 May 2004 20:30:38 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i453Ubqp074870; Tue, 4 May 2004 20:30:37 -0700 (PDT) (envelope-from obrien) Date: Tue, 4 May 2004 20:30:37 -0700 From: "David O'Brien" To: Tim Kientzle , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Andrew.Li@alcatel.com.au Message-ID: <20040505033037.GA74624@dragon.nuxi.com> References: <200405041721.i44HL22l029797@repoman.freebsd.org> <20040504232632.GA69416@gsmx07.alcatel.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040504232632.GA69416@gsmx07.alcatel.com.au> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Subject: Re: cvs commit: src/usr.bin/tar fts.c fts.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2004 03:31:06 -0000 On Wed, May 05, 2004 at 09:26:32AM +1000, Peter Jeremy wrote: > On 2004-May-04 10:21:02 -0700, Tim Kientzle wrote: > >kientzle 2004/05/04 10:21:02 PDT > > Added files: > > usr.bin/tar fts.c fts.h > > Log: > > Include local copies of fts.c and fts.h to be used ONLY on non-FreeBSD > > systems. The fts.h here is an exact copy of include/fts.h (except for > > an initial explanatory comment and the revision tags, of course). The > > fts.c here is slightly modified from lib/libc/gen/fts.c so it can > > compile correctly on non-FreeBSD systems. ... > be usable on anything other than Linux systems due to the '#ifdef LINUX' > near the top - if this was '#ifndef __FreeBSD__', the portability would > be enhanced. Also why spell it "#ifdef LINUX" vs. what all compilers already define for you -- "#ifdef linux" (or "#ifdef __gnu_linux__")? -- -- David (obrien@FreeBSD.org)