From owner-svn-src-head@FreeBSD.ORG  Tue Sep  4 08:11:26 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3ED28106566C;
	Tue,  4 Sep 2012 08:11:26 +0000 (UTC) (envelope-from ray@dlink.ua)
Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146])
	by mx1.freebsd.org (Postfix) with ESMTP id E480D8FC0C;
	Tue,  4 Sep 2012 08:11:25 +0000 (UTC)
Received: from terran.dlink.ua (unknown [192.168.10.90])
	(Authenticated sender: ray)
	by smtp.dlink.ua (Postfix) with ESMTPSA id 0249BC493C;
	Tue,  4 Sep 2012 11:11:20 +0300 (EEST)
Date: Tue, 4 Sep 2012 11:13:22 +0300
From: Aleksandr Rybalko <ray@dlink.ua>
To: Konstantin Belousov <kostikbel@gmail.com>
Message-Id: <20120904111322.e54bf030.ray@dlink.ua>
In-Reply-To: <20120903170208.GQ33100@deviant.kiev.zoral.com.ua>
References: <201209030852.q838q6lC053405@svn.freebsd.org>
	<CAMBSHm93ct9GCc_S6D8N15bAkitU3jTWr2_5P5Z4maQ5oim8PQ@mail.gmail.com>
	<20120903170208.GQ33100@deviant.kiev.zoral.com.ua>
Organization: D-Link
X-Mailer: Sylpheed 2.7.1 (GTK+ 2.20.1; i386-portbld-freebsd8.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, mdf@freebsd.org,
	Aleksandr Rybalko <ray@freebsd.org>, src-committers@freebsd.org,
	svn-src-all@freebsd.org
Subject: Re: svn commit: r240067 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Sep 2012 08:11:26 -0000

On Mon, 3 Sep 2012 20:02:08 +0300
Konstantin Belousov <kostikbel@gmail.com> wrote:

>> On Mon, Sep 03, 2012 at 09:09:08AM -0700, mdf@freebsd.org wrote:
>> > On Mon, Sep 3, 2012 at 1:52 AM, Aleksandr Rybalko
>> > <ray@freebsd.org> wrote:
>> > > Author: ray
>> > > Date: Mon Sep  3 08:52:05 2012
>> > > New Revision: 240067
>> > > URL: http://svn.freebsd.org/changeset/base/240067
>> > >
>> > > Log:
>> > >   Add kern.hintmode sysctl variable to show current state of
>> > > hints: 0 - loader hints in environment only;
>> > >   1 - static hints only
>> > >   2 - fallback mode (Dynamic KENV with fallback to kernel
>> > > environment) Add kern.hintmode write handler, accept only value
>> > > 2. That will switch static KENV to dynamic. So it will be
>> > > possible to change device hints.
>> > >
>> > >   Approved by:  adrian (mentor)
>> > >
>> > > Modified:
>> > >   head/sys/kern/subr_hints.c
>> > >
>> > > Modified: head/sys/kern/subr_hints.c
>> > > ==============================================================================
>> > > --- head/sys/kern/subr_hints.c  Mon Sep  3 07:18:24 2012
>> > > (r240066) +++ head/sys/kern/subr_hints.c  Mon Sep  3 08:52:05
>> > > 2012        (r240067) @@ -29,8 +29,10 @@ __FBSDID("$FreeBSD$");
>> > >
>> > >  #include <sys/param.h>
>> > >  #include <sys/lock.h>
>> > > +#include <sys/malloc.h>
>> > >  #include <sys/mutex.h>
>> > >  #include <sys/systm.h>
>> > > +#include <sys/sysctl.h>
>> > 
>> > Putting on my style-nazi hat.  sysctl comes before systm
>> > alphabetically.
>> Systm.h is very special, it normally comes as the second item in the
>> include list, right after param.h.

Just recheck, in that case there is indeed no requirement to swap
sysctl.h and systm.h.

Thanks Kostik!

Will fix my style(9)ability :)

WBW
-- 
Alexandr Rybalko <ray@dlink.ua> 
aka Alex RAY <ray@ddteam.net>