From owner-svn-src-all@FreeBSD.ORG Mon Aug 19 18:45:36 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C97D2BD2; Mon, 19 Aug 2013 18:45:36 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-bk0-x22b.google.com (mail-bk0-x22b.google.com [IPv6:2a00:1450:4008:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CCE27215A; Mon, 19 Aug 2013 18:45:35 +0000 (UTC) Received: by mail-bk0-f43.google.com with SMTP id mz13so1523592bkb.2 for ; Mon, 19 Aug 2013 11:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=OrhYuwj13dxVpqVdsjDBpCrTRaXXPkXUJDzfr4QhjGI=; b=g775faM1OUG3x6PW/9/1V16N2qfLF/GXkwlYDmmIMiI6Av3z6GHfxbM5w7Q+QwPUDY OcbM32zNSxlX9fivIJYM/kjceOn+mLTZtGcLPOJsjEkhR+rDSgBtrBcdk/SLCyhQZPN8 vyTggHb3CZSY31EL+ZS0P0x9ed8uYrrOyZjk3na2A7Mi4t+nJduIUz8JxW0okKASincO 27GkaAVFrqJCn0rhj2YfX94nZavw4sJITyeP4pV4qnumvuYJIrm+XMU5V/hFdaB6U2nI av732zUwXxjH+srnk8sOgobJ1kJl+4kmd0CzRjB2cc0pbP3l79CaUiF6ulRpbQsH2vIX Vigg== X-Received: by 10.205.7.6 with SMTP id om6mr9056417bkb.18.1376937934002; Mon, 19 Aug 2013 11:45:34 -0700 (PDT) Received: from [192.168.0.10] (89-67-85-20.dynamic.chello.pl. [89.67.85.20]) by mx.google.com with ESMTPSA id d8sm2137563bkj.6.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 19 Aug 2013 11:45:33 -0700 (PDT) Sender: Mario Oshogbo Message-ID: <521267C2.60001@FreeBSD.org> Date: Mon, 19 Aug 2013 20:45:22 +0200 From: Mario Oshogbo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Hiroki Sato Subject: Re: svn commit: r254440 - head/usr.sbin/rwhod References: <201308170712.r7H7CrYi089636@svn.freebsd.org> In-Reply-To: <201308170712.r7H7CrYi089636@svn.freebsd.org> X-Enigmail-Version: 1.5.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="64VWb3C3MNmmuEwkUchIEgpeenqcTK6PI" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Aug 2013 18:45:37 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --64VWb3C3MNmmuEwkUchIEgpeenqcTK6PI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thank you for your commit and sorry for not repair this problem earlier. > @@ -274,6 +274,15 @@ main(int argc, char *argv[]) > exit(1); > if (!quiet_mode) { > pid_child_receiver =3D pdfork(&fdp, 0); > + if (pid_child_receiver =3D=3D -1) { > + if (errno !=3D ENOSYS) { > + syslog(LOG_ERR, "pdfork: %m"); > + exit(1); > + } else { > + pid_child_receiver =3D fork(); > + fdp =3D -1; > + } > + } We can't do it this way. pdfork() is used there to prevent killing only one process. If we use fork() and we kill parent process the second process (child process) will become a zombie process. I suggest to revert this change. The changes that Pawel commit (r254486 (thx jilles!!!) and r254480) should resolve all problems. Cheers, oshogbo --64VWb3C3MNmmuEwkUchIEgpeenqcTK6PI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJSEmfKAAoJECRkYejLhN/j110P+wSFH6758IUP7EpStQ3vNAtR k1+bjZo/nLnhP3uu2UlBrYhurNmIh3ch4lkdnn/ah5PlzUUBugdHKuTJP68cWND4 2Ks1H5gK0zucnJDdnvFeBwOdbGFXEdzv2otO7vm6bULe1AgtaHFNGCkmhlMZLaY+ 4K9CmzePOAmwuN2BKkv810F013lcX7jh8910hZrwSlgFkICDwdzX2BVou4mmAhIb 3oHgvNG9bE87377D2UYjn4teN+/Saa0BLqtrujuVF8rF4XHpT469cLTVCHs/7CPz cD5CtWyEHQvGgBvssEB//dZ7+j7Q11u+UJ118ZoCruH3mpTfbHyE6L75evTQzoX2 /reDeIydpWn6xtZz2bd0XOWjDA8PQej6DdmLt1wwiOfrRpiDabSduXE++flcuPwr 5T6eJGu68IedxE+O4mFU131FT1Gq+olT8X0I+C+K9Hc63gVPXZE0vfaR5epAGWlx lvMLTKZ6bJn7p5uy5yetgulcxxrY73u0ha20OVgIZ9jOiW55e6f9CgfAALG0aqiZ 0G7cSwNwkpzQ63tdO705vHfjjxI72Pgr53UyXaou5M9DTBOhTNHzBA4ffkIZhbVy j/3dAsvRCnbFbb+8+4rnxP+YEiHdzsAFPqnNaLePziE8MZBWYCVPtFyRdOU2LzBt gBk+3kglVFTwBLJFk5U+ =R5sD -----END PGP SIGNATURE----- --64VWb3C3MNmmuEwkUchIEgpeenqcTK6PI--