From owner-svn-src-user@FreeBSD.ORG  Fri Nov 23 06:44:15 2012
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 9EA0645D;
 Fri, 23 Nov 2012 06:44:15 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
 by mx1.freebsd.org (Postfix) with ESMTP id 12DBD8FC0C;
 Fri, 23 Nov 2012 06:44:14 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id qAN6iD51088776;
 Fri, 23 Nov 2012 10:44:13 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id qAN6iDv1088775;
 Fri, 23 Nov 2012 10:44:13 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 23 Nov 2012 10:44:13 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andre Oppermann <andre@FreeBSD.org>
Subject: Re: svn commit: r243414 - user/andre/tcp_workqueue/sys/net
Message-ID: <20121123064413.GG84121@FreeBSD.org>
References: <201211222043.qAMKh9Zs060179@svn.freebsd.org>
 <CAPBZQG1kYUNBhX5=P=Ja9rPuT45rizXP6sq+ZP0fv13mD7nJUw@mail.gmail.com>
 <50AEA39D.4080704@freebsd.org>
 <CAPBZQG2O4hdLM6mKGQo75Eo-oDo+riG9Q+M7TjY2zJVmBnYfLA@mail.gmail.com>
 <50AEB2CF.3040904@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <50AEB2CF.3040904@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Ermal Lu?i <eri@FreeBSD.org>, src-committers@FreeBSD.org,
 svn-src-user@FreeBSD.org
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Nov 2012 06:44:15 -0000

On Fri, Nov 23, 2012 at 12:18:39AM +0100, Andre Oppermann wrote:
A> > On Thu, Nov 22, 2012 at 11:13 PM, Andre Oppermann <andre@freebsd.org <mailto:andre@freebsd.org>> wrote:
A> >
A> >         Hello Andre,
A> >         you plan to introduce pfil(9) at layer2 as well?
A> >
A> >     We already have that in net/if_ethersubr.c for ethernet at least.
A> >
A> > Hmm have missed the addition of that one.
A> > I would have liked that with that hook all the special cases(bridge/netgraph/carp/... to go away.
A> 
A> Indeed.  Lets make it happen. :-)

It is impossible to convert netgraph to be a pfil, since netgraph isn't
just a function call. It doesn't return processed packet immediately.

The carp(4) isn't a layer 2 protocol, but is IP protocol, so I
don't understand how can it be converted to a pfil hook.

-- 
Totus tuus, Glebius.