From owner-freebsd-testing@freebsd.org Sun Jun 28 21:15:28 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54A8998FEC9; Sun, 28 Jun 2015 21:15:28 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-yk0-x22d.google.com (mail-yk0-x22d.google.com [IPv6:2607:f8b0:4002:c07::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 13F191C96; Sun, 28 Jun 2015 21:15:28 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: by ykdy1 with SMTP id y1so99763278ykd.2; Sun, 28 Jun 2015 14:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=r4uIhH61bAkMN3+Q0UbnTIPdi4DNMlnOEPik/LGa+uQ=; b=o76ZMrt30BvMlfh0HqLUhB3XRORkqfz8RlIASm0C4rfd6QC9tyXFtpkeHp4J0dDxgN HI1RsLDHD3/ARlfTdBAeYW4/U3VG6lYrpzEQBowHBtjsJONsJPIS/tFfQjg3BNTpDkXb cTIYUfXp6HAGr+YAVROnSIDFtvXUHaAeWJMNA1Z5lHpspEZh87PH7MNT5uDc5O1kTF0e mkAWGF8F6micMdn9M7UIcYkTpWI9LeV35DUhPsBQBSBLW6Yg69ixpq8No93273+kX7uC TQdPBP1lkKFVi/NyTVmjuwCtM1rR5nTnX0oOpXunk0rVzRAwadniQSzOzEVKWBFdQd4w fJuw== MIME-Version: 1.0 X-Received: by 10.170.154.212 with SMTP id v203mr15256162ykc.0.1435526127206; Sun, 28 Jun 2015 14:15:27 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.37.39.130 with HTTP; Sun, 28 Jun 2015 14:15:27 -0700 (PDT) In-Reply-To: <558C62B6.6030004@FreeBSD.org> References: <8CA148D7-81AF-41F8-AA41-9D7700B27242@neville-neil.com> <558C62B6.6030004@FreeBSD.org> Date: Sun, 28 Jun 2015 17:15:27 -0400 X-Google-Sender-Auth: 41iP01Vf1XSSP29oIGFIwA_McSU Message-ID: Subject: Re: Requests for Help: add FreeBSD procstat support to akuma library for Jenkins From: Craig Rodrigues To: Jung-uk Kim Cc: George Neville-Neil , "freebsd-testing@freebsd.org" , "freebsd-java@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2015 21:15:28 -0000 On Thu, Jun 25, 2015 at 4:21 PM, Jung-uk Kim wrote: > You can try the attached trivial patch. Note it requires procfs(5). > > Thanks for submitting that patch. I thought about something like that before. I am hesitant about pushing this patch upstream, because it would make akuma + Jenkins dependent on procfs. This dependency would be new, since FreeBSD procfs is not mandatory and only available as an option. Since procstat has been available in the base system since FreeBSD 7.1, I recommended using that in the akuma library, even though it is a little bit more work to implement. -- Craig