From nobody Thu Nov 30 00:38:15 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sgck02NCZz52V6S; Thu, 30 Nov 2023 00:38:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sgcjz73q6z3MYZ; Thu, 30 Nov 2023 00:38:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701304696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hWla75ZU7CDt8xgq4F1ALTHtmJLrkQYTnUZwKXMvmaE=; b=gT1vcHL3jbxyMpm/xM/UTalSzirUXbrKmJ/rUt2Gw7i+1kNfjLJ4dCoRXIlMpLfMNcfHaA Q3HRi2aipFH0e513qNJDZrj4bhdfRqWodnvC1o27QVSpE9Hs2rSdtRzL5GguiqYlMwUTle gzp1XIXVo7x+ivk3KyvhC9x2ZkDVfYk4O/HCxBQ2kinttqCnTzTVC4UvMKyZ9VybC6wZZm EsLnMa2mHGMG2SA3Ro9uC6RqXe2ebHXi2ctc7Dc+UmIi+w1hasWUxI6DJoHwxuJaYK22ZX vVW6Wd9I5Ev1y1tV/TizuBtQsy01Cfw9i61qEtQ4GLYTBQlHCLSkvZVtUNW6pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701304696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hWla75ZU7CDt8xgq4F1ALTHtmJLrkQYTnUZwKXMvmaE=; b=nIj0zBnhPQsGA8Tp8EOcImnDE2sG8WlkMFn0vjvFikmkP3JD/d0lMBe25U1WraSAF2XtRt SV3r5hsEohGOALuhnTzYKFC/q0CWuBuGNHu0aGvTRVjgKil/SG5lBlzkvHM/spkBeY9DhN YxQEFFlhMDWoqaR1IcVq36vG41v9z9OT7ZCj3ZpguVN2gdB1xE8oikKdZUsw7rQBkoDnT4 Yen8I3/JMnDQ9XJ4b+SaQPCd2xQAcUYMRaOlMYSS4y88f+oa0h4DWMqkqs/ndxOu4Xy2Fg UJ6+/74N4BaOMdOD0LJ+kGmLHIY3vBbRuP4W9khN6cC6zMmHL+7/M1hPhfpo6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701304696; a=rsa-sha256; cv=none; b=LjUGbA196v+10vUj1iLzjGHszWptE+lsIVv2Cjtg5lQ7N2eQGv2OcZPExBp4/T2c3ibW+h 0Pnpaha23df8iP1AVen5ODVpQ8y1ojDdOayKVREK8TdGeLD2tnP1tfdziCs7FO23OnW4do pPHmNPQ554YJI7aF33sp/SP/PE0QYPxypJG+ric9l3EP8WXF3sLUm4fsWSSUAyM5OPnOzn tZmyMzXBDyrRs0NYmjrEIjCHU/VibfIKgP0ucnMILl/mS+URcEKMy47nBGPFcyqXTURRDm 4n5g7Fs5Bk5dT41uZMzewbTORb5xWf7J8kTS362AiNHvpklWhS+NghjqNIKTyg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Sgcjz69XwzD8q; Thu, 30 Nov 2023 00:38:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3AU0cFcq051938; Thu, 30 Nov 2023 00:38:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3AU0cF0b051935; Thu, 30 Nov 2023 00:38:15 GMT (envelope-from git) Date: Thu, 30 Nov 2023 00:38:15 GMT Message-Id: <202311300038.3AU0cF0b051935@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: d27f3b8c7e64 - stable/14 - iwlwifi: re-enable "Invalid TXQ id" logging List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d27f3b8c7e6486ed0750286d7ec65e61935ce409 Auto-Submitted: auto-generated The branch stable/14 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=d27f3b8c7e6486ed0750286d7ec65e61935ce409 commit d27f3b8c7e6486ed0750286d7ec65e61935ce409 Author: Bjoern A. Zeeb AuthorDate: 2023-10-09 19:47:39 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-11-30 00:36:57 +0000 iwlwifi: re-enable "Invalid TXQ id" logging Various reports recently hit the "Invalid TXQ id" in iwlwifi again. Unconditionally enable logging and add a note to report to a specific PR in the log message for now. Along with 018d93ece16b this will hopefully help us to understand what is going on. Sponsored by: The FreeBSD Foundation PR: 274382 (cherry picked from commit ad134f8ab768e3b1d2db203f1cc963bdf0eea857) --- sys/contrib/dev/iwlwifi/mvm/tx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sys/contrib/dev/iwlwifi/mvm/tx.c b/sys/contrib/dev/iwlwifi/mvm/tx.c index 2407d0ee832e..da33c1a5cc46 100644 --- a/sys/contrib/dev/iwlwifi/mvm/tx.c +++ b/sys/contrib/dev/iwlwifi/mvm/tx.c @@ -1199,9 +1199,10 @@ static int iwl_mvm_tx_mpdu(struct iwl_mvm *mvm, struct sk_buff *skb, if (WARN_ONCE(txq_id == IWL_MVM_INVALID_QUEUE, "Invalid TXQ id")) { #if defined(__FreeBSD__) - IWL_DEBUG_TX(mvm, "fc %#06x tid %u txq_id %u mvm %p " - "skb %p { len %u } info %p sta %p\n", fc, - tid, txq_id, mvm, skb, skb->len, info, sta); + printf("%s:%d: fc %#06x tid %u txq_id %u mvm %p " + "skb %p { len %u } info %p sta %p (if you see this please " + "report to PR 274382)\n", __func__, __LINE__, + fc, tid, txq_id, mvm, skb, skb->len, info, sta); #endif iwl_trans_free_tx_cmd(mvm->trans, dev_cmd); spin_unlock(&mvmsta->lock);