From owner-svn-ports-all@FreeBSD.ORG Fri Mar 22 15:12:06 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 0ABDE6D2; Fri, 22 Mar 2013 15:12:06 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-ea0-x22b.google.com (mail-ea0-x22b.google.com [IPv6:2a00:1450:4013:c01::22b]) by mx1.freebsd.org (Postfix) with ESMTP id 237133D3; Fri, 22 Mar 2013 15:12:04 +0000 (UTC) Received: by mail-ea0-f171.google.com with SMTP id b15so1414051eae.30 for ; Fri, 22 Mar 2013 08:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=L12FwgLX30BB4lLodOTRmsFQXpDXfqbSQENEj2/357Q=; b=eYYqQ5rG6KbnzhTRRckL2SBq4MC5pxvdccfT6rLmaSmP5soJJcx7sBp6PX4dc04gcz ptlFAXj3Z6POlgQssudXswwswMJ0gNJWO1QWbJyVmSVV5tVGdDimez4uf8xFSzgSmXM6 VStlIDDiGCsYW99GZ472ZFkmtNrqYpnUymdJu+qN5G82++uu/OP4YjWuqxl1qcZeKeif 1BcRI058PsdkOnnAojbpaewmvDsUxJsuinMsZ8s52wvitDKBf+vBvlqnVwTUmyBuT2rw V/S8oxdxzQGP0Ntm3RcBNomxsekPyN9bM3+YhvihVMzT5YVq+TyfelVpFfkF/7Oylzs4 5dNA== X-Received: by 10.14.1.130 with SMTP id 2mr6049157eed.15.1363965124274; Fri, 22 Mar 2013 08:12:04 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id f47sm3535858eep.13.2013.03.22.08.12.02 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 22 Mar 2013 08:12:03 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 22 Mar 2013 16:12:00 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r314859 - head/palm/jpilot Message-ID: <20130322151200.GA14206@ithaqua.etoilebsd.net> References: <201303211827.r2LIRHrh078301@svn.freebsd.org> <514C6DEF.10201@passap.ru> <20130322145344.GA16844@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <20130322145344.GA16844@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Boris Samorodov , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2013 15:12:06 -0000 --azLHFNyN32YCQGCU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 22, 2013 at 02:53:44PM +0000, Alexey Dokuchaev wrote: > On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote: > > 21.03.2013 22:27, Baptiste Daroussin =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > --- head/palm/jpilot/Makefile Thu Mar 21 18:25:04 2013 (r314858) > > > +++ head/palm/jpilot/Makefile Thu Mar 21 18:27:17 2013 (r314859) > > [...] > > > -# "?=3D" and "+=3D" are for including this Makefile from japanese/jp= ilot > >=20 > > Not particular to this commit, but rather a general question: > > what is our current policy on comments at the makefile headers? > > I mean non-standard comments (maintainer tips, etc.). Should > > they be deleted? >=20 > I would not delete them (in general case). In this particular case I ass= ume > they were deleted because they were stating quite obvious thing: certain > variables with +=3D/?=3D are clear indication of master/slave relationshi= p. >=20 > ./danfe Deleting was a mistake, I will readd them once I'm back on a box where I can commit on the ports tree. Meaning probably monday. Except if somone wants to do it now, he gets my approval. regards, Bapt --azLHFNyN32YCQGCU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFMdMAACgkQ8kTtMUmk6EzcVACdFUimXZ+aKTDf1SouEgdATJmY 6I8AoKzRWiXceuYdxo+zveYLVkLv9AgF =Rvfw -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--