From owner-svn-src-all@FreeBSD.ORG Mon Jun 2 19:27:48 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC913FB3; Mon, 2 Jun 2014 19:27:48 +0000 (UTC) Received: from mail-qa0-x233.google.com (mail-qa0-x233.google.com [IPv6:2607:f8b0:400d:c00::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 470DF2B24; Mon, 2 Jun 2014 19:27:48 +0000 (UTC) Received: by mail-qa0-f51.google.com with SMTP id w8so3451217qac.10 for ; Mon, 02 Jun 2014 12:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=kz277CSPOZZwUhW3b5+TjXbivv57pTSnSEOEM7S1gj4=; b=j17Aaxa8MUTlwQz8T3G7uV7TVfm/oCVa7XvIyjbx0Fe7uOxsm3dl3C0IhYPbnh13ec dtrke/GNDzL5iofN8LjLmlp1malqkd5LY/jeeoqR+KdAWjbEAz+xgRdIH7ESNFvz6wqN cn6jNIwWvzl6DMEgg04Rxif8tqzygE9DIGEChwgNGZBcNbZOkDrGDTcJ7QevALKE06TV r3hWoPuxS33FB9mUBRoisTTaCNRMYzlOPyKpdo0ELguLai8HpA0dDYpcWI591LFXGydc UcNegjwRUFAWkGz++samP/Fh+FeuNj+Gk1ABW6iWt6mvaN/2CC62KLONXLrNue2YaG7I H9tg== MIME-Version: 1.0 X-Received: by 10.140.22.209 with SMTP id 75mr48696450qgn.4.1401737267479; Mon, 02 Jun 2014 12:27:47 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.43.134 with HTTP; Mon, 2 Jun 2014 12:27:47 -0700 (PDT) In-Reply-To: <1401735801.20883.103.camel@revolution.hippie.lan> References: <201406021754.s52Hsd1B039620@svn.freebsd.org> <1401735801.20883.103.camel@revolution.hippie.lan> Date: Mon, 2 Jun 2014 12:27:47 -0700 X-Google-Sender-Auth: Jix-BtB6BabmHe9Ue5W7dsqvC7c Message-ID: Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net From: Adrian Chadd To: Ian Lepore Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Marcel Moolenaar , "src-committers@freebsd.org" , Marcel Moolenaar X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 19:27:48 -0000 On 2 June 2014 12:03, Ian Lepore wrote: > On Mon, 2014-06-02 at 11:42 -0700, Marcel Moolenaar wrote: >> On Jun 2, 2014, at 11:27 AM, Adrian Chadd wrote: >> >> > .. and actually, bikeshedding for a moment, would we be able to move a >> > lot of these accessor methods over to inlines? Would that break the >> > Juniper way of doing things? >> >> That would definitely break Juniper as it doesn't give a stable >> ABI. >> >> I've suggested an approach that allows for both, but it was deemed >> unnecessary. The argument being that the function call overhead is >> negligible. >> >> We can always revisit that decision if needed... >> > > In my experience, function call overhead is anything but minimal, > especially on ARM platforms. Same on MIPS. -a