From owner-freebsd-ports@FreeBSD.ORG Tue Aug 24 11:17:59 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E2F416A4D1 for ; Tue, 24 Aug 2004 11:17:59 +0000 (GMT) Received: from bast.unixathome.org (bast.unixathome.org [66.11.174.150]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40C4A43D58 for ; Tue, 24 Aug 2004 11:17:59 +0000 (GMT) (envelope-from dan@langille.org) Received: from wocker (wocker.unixathome.org [192.168.0.99]) by bast.unixathome.org (Postfix) with ESMTP id 87D993D3D; Tue, 24 Aug 2004 07:17:58 -0400 (EDT) From: "Dan Langille" To: Kris Kennaway Date: Tue, 24 Aug 2004 07:17:58 -0400 MIME-Version: 1.0 Message-ID: <412AEBA6.17012.839357E2@localhost> Priority: normal In-reply-to: <20040824055238.GA52583@xor.obsecurity.org> References: <412A3ED0.12730.80F02992@localhost> X-mailer: Pegasus Mail for Windows (v4.12a) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Content-description: Mail message body cc: ports@freebsd.org cc: Oliver Eikemeier Subject: Re: LATEST_LINK unique or not? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2004 11:17:59 -0000 On 23 Aug 2004 at 22:52, Kris Kennaway wrote: > On Mon, Aug 23, 2004 at 07:00:32PM -0400, Dan Langille wrote: > > On 24 Aug 2004 at 0:37, Oliver Eikemeier wrote: > > > > > Dan Langille wrote: > > > > > > > Is LATEST_LINK supposed to be unique? It's not. There's about 201 > > > > ports which have duplicate values. > > > > > > It is, expect when NO_LATEST_LINK is set (in which case no latest link > > > exists). Did you filtr out these cases? Everything else is bug, Kris did > > > some survey AFAIK. > > > > I obtained my list from the output of "make -V LATEST_LINK" and paid > > no attention to NO_LATEST_LINK. > > > > Are you saying LATEST_LINK must be ignored if NO_LATEST_LINK is set? > > Why is this not done programatically? i.e. output an empty string. > > The only reason is because LATEST_LINK was originally used only within > bsd.port.mk in situations where NO_LATEST_LINK is tested. Perhaps > you're using it for something else now that might justify changing the > behaviour. I added the LATEST_LINK value to FreshPorts because I was told it was the name of the package. This information is now used to provide this information: To add the package: pkg_add -r bacula LATEST_LINK may also be used by other websites that wish to link to FreshPorts but have only the package name. This differs from the conventional category/port path used by FreshPorts. For example, http://beta.freshports.org/?package=bacula will redirect you to http://beta.freshports.org/sysutils/bacula/ It would be good if LATEST_LINK was empty if it was not meant to be used. However, I don't want to break existing usage if we do that. A quick check of the first two pairs of duplicates listed at http://beta.freshports.org/tmp/latest_link_duplicates.txt: [dan@polo:/usr/ports/x11-wm/afterstep] $ make -V LATEST_LINK -V NO_LATEST_LINK afterstep yes [dan@polo:/usr/ports/x11-wm/afterstep] $ cd ../afterstep-stable/ [dan@polo:/usr/ports/x11-wm/afterstep-stable] $ make -V LATEST_LINK - V NO_LATEST_LINK afterstep [dan@polo:/usr/ports/x11-wm/afterstep-stable] $ [dan@polo:/usr/ports/shells/bash1] $ make -V LATEST_LINK -V NO_LATEST_LINK bash yes [dan@polo:/usr/ports/shells/bash1] $ cd ../bash2 [dan@polo:/usr/ports/shells/bash2] $ make -V LATEST_LINK -V NO_LATEST_LINK bash [dan@polo:/usr/ports/shells/bash2] $ -- Dan Langille : http://www.langille.org/