Date: Mon, 06 Jan 2003 20:56:45 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: current@FreeBSD.ORG, ryanb@goddamnbastard.org Subject: Re: if_dc.c locking patch Message-ID: <20030106.205645.132444987.imp@bsdimp.com> In-Reply-To: <Pine.BSF.4.21.0301061642240.12472-200000@root.org> References: <20030104074914.GS311@goddamnbastard.org> <Pine.BSF.4.21.0301061642240.12472-200000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Wouldn't it be better if you didn't do the bogus locking in the attach routine? It would be better to not lock at all and not initialize the ISR until last. That's what I did with if_rl. Let's not work around the bogus locking, but insteal eliminate it. There's no way that the driver can interrupt itself until an interrupt happens. If there's no way to interrupt, no locking is needed :-) Also, most of the driver locking that's in the tree is likely bogus anyway, since the network stack still uses giant to a large extent. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030106.205645.132444987.imp>