From owner-freebsd-ports@FreeBSD.ORG  Thu Aug 13 04:05:10 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 76C96106566B
	for <ports@freebsd.org>; Thu, 13 Aug 2009 04:05:10 +0000 (UTC)
	(envelope-from stephen@missouri.edu)
Received: from cauchy.math.missouri.edu (cauchy.math.missouri.edu
	[128.206.184.213])
	by mx1.freebsd.org (Postfix) with ESMTP id 407238FC3D
	for <ports@freebsd.org>; Thu, 13 Aug 2009 04:05:09 +0000 (UTC)
Received: from cauchy.math.missouri.edu (localhost [127.0.0.1])
	by cauchy.math.missouri.edu (8.14.3/8.14.3) with ESMTP id
	n7D459wI022552; Wed, 12 Aug 2009 23:05:09 -0500 (CDT)
	(envelope-from stephen@missouri.edu)
Received: from localhost (redmail@localhost)
	by cauchy.math.missouri.edu (8.14.3/8.14.3/Submit) with ESMTP id
	n7D458uP022549; Wed, 12 Aug 2009 23:05:08 -0500 (CDT)
	(envelope-from stephen@missouri.edu)
X-Authentication-Warning: cauchy.math.missouri.edu: redmail owned process
	doing -bs
Date: Wed, 12 Aug 2009 23:05:08 -0500 (CDT)
From: Stephen Montgomery-Smith <stephen@missouri.edu>
X-X-Sender: redmail@cauchy.math.missouri.edu
To: "Jason J. Hellenthal" <jasonh@DataIX.net>
In-Reply-To: <20090812235715.fc28351d.jasonh@DataIX.net>
Message-ID: <alpine.BSF.2.00.0908122301500.18098@cauchy.math.missouri.edu>
References: <200908122011.20408.lumiwa@gmail.com>
	<20090812221059.4f437ed4.jasonh@DataIX.net>
	<alpine.BSF.2.00.0908122143230.18098@cauchy.math.missouri.edu>
	<20090812235715.fc28351d.jasonh@DataIX.net>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Stephen Montgomery-Smith <stephen@missouri.edu>, ports@freebsd.org,
	ajtiM <lumiwa@gmail.com>
Subject: Re: ImageMagick 6.5.4.10
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2009 04:05:10 -0000



On Wed, 12 Aug 2009, Jason J. Hellenthal wrote:

> On Wed, 12 Aug 2009 21:44:39 -0500 (CDT)
> Stephen Montgomery-Smith <stephen@missouri.edu> wrote:
>
>>
>>
>> On Wed, 12 Aug 2009, Jason J. Hellenthal wrote:
>>
>>> On Wed, 12 Aug 2009 20:11:20 -0500
>>> ajtiM <lumiwa@gmail.com> wrote:
>>>
>>>> Update to 6.5.4.10 on FreeBSD 7.2
>>>>
>>>> magick/.libs/libMagickCore.so: undefined reference to `carg'
>>>> *** Error code 1
>>
>> Try this patch:
>>
>> diff -u magick/fourier-orig.c magick/fourier.c
>> --- magick/fourier-orig.c       2009-08-13 02:39:18.000000000 +0000
>> +++ magick/fourier.c    2009-08-13 02:40:13.000000000 +0000
>> @@ -515,7 +515,7 @@
>>         for (x=0L; x < (long) fourier_info->center; x++)
>>         {
>>           magnitude[i]=cabs(fourier[i]);
>> -        phase[i]=carg(fourier[i]);
>> +        phase[i]=atan2(cimag(fourier[i]),creal(fourier[i]));
>>           i++;
>>         }
>>     else
>>
>
> I conclude this fixes the problem on 7.2-RELEASE-p3/i386 Non-SMP

I submitted the fix at ports/137712

The function carg seems to have been introduced in FreeBSD 8.  If you look 
inside /usr/src/lib/msun/src/s_carg.c (on a machine with FreeBSD 8) you 
will see that the replacement I provided provides EXACTLY the same 
functionality.