From nobody Mon Jul 7 23:18:18 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbgCH23Wvz61VMX; Mon, 07 Jul 2025 23:18:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbgCG65kkz41Bd; Mon, 07 Jul 2025 23:18:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751930298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C3aPPtUXBN5wwrkaA8Ef+19UKK1Wtfni1BUuIV+NtRk=; b=t3izSVrA5xfFK6Nsee0OkugNUvkE9fdXvqCk7DHGZeqGu0rcnmWztf6613wPmSWUinvMM6 0sm6ce5jV1FKimoRZjWtySfcTyZvXIjm250ozbbHSnXBlN/mMkjYy+FGfaez6VXgIBMfG0 XgjnULWE1TcfXgzXBlNCsV2BCXTF/4M6MkgeS+nQQKnvqquvg/jn1HNfGgBdNG9kEFjj4h TGzdEe2L8YMpatLze5PSU/GvLtGa20Ew25enDUX1ooDGgtgD4GDfRgpMv9q7fzILst1rEp GhfG9a5OGv1s1UsjIgAhUh7NV+IVQg0mnjnq4k8TTOoQ68vbhUc8i5QuNSEiEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751930298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C3aPPtUXBN5wwrkaA8Ef+19UKK1Wtfni1BUuIV+NtRk=; b=HfgmNIjc9tiIoIWlm7aI8UatrDNxDirmL6XeURIEbsPHgeQTCvkDeXiu8IJ6pT72ny8HHF 2Mg5tjwwm++bbqo3kkMbRv38Xu4Y6YTuH10Aof+OYyJj0QB0Q76d8a+K9EmyflCpFA4dR9 zJu4qm6tnsICAlvY/CwdHnJa6r9OtYfa9i8z4xS7ykTp/TziTnWDilo8PSi0mX5xJ8D71N NuIoJt8D8ioMTK8yK9q87jCZ45LBqccZvgNno99WX2vcCEIEUdCcWHCkR2RhBaK158fdp+ 1a2cFo5UJcULc93jzeADTRl4UTLQLUZtk3v8dxvTuXnKcqKoVvrw8GA1omNdPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751930298; a=rsa-sha256; cv=none; b=xXeOqDth1/VTU5UTIlfvf1QSVevtHdFMg/NwrsnTqSPaWKu2PvRPcUkw4j+ioxYR+7j+8A efb4cDkskePzghtVQS6XW2KRaTYLmqzOlvo2hRjmcP9fBBQ9tM02mRiGP1etoNSI+13yqB gfhFLPDYqQUfln1ESJuBsT0u+cgjrDmUlmNiIU0ppR2IcuESFJi9NjPrx2Z7ohAKdt5UVq 8J7qGozDW6uF7SwvjYGSn3Ka6cAGn5y7N1yT3qzXjXGEc9Alv6jJUUAl5fMD+ijMDWtZiW vlgFrpI5ZDI42imnWoI0qP00gyTF6naoHnJK5+jnvhhCI9jb6izddqgfBixfag== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bbgCG5YLcz19m5; Mon, 07 Jul 2025 23:18:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 567NIISD045618; Mon, 7 Jul 2025 23:18:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 567NIIML045615; Mon, 7 Jul 2025 23:18:18 GMT (envelope-from git) Date: Mon, 7 Jul 2025 23:18:18 GMT Message-Id: <202507072318.567NIIML045615@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 034b3515ea27 - main - cam/xpt: improve comment on xpt_path_inq List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 034b3515ea274b144eb514e83b2e10be0e5b71a9 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=034b3515ea274b144eb514e83b2e10be0e5b71a9 commit 034b3515ea274b144eb514e83b2e10be0e5b71a9 Author: Warner Losh AuthorDate: 2025-07-07 20:04:33 +0000 Commit: Warner Losh CommitDate: 2025-07-07 23:17:00 +0000 cam/xpt: improve comment on xpt_path_inq Fix a comment about bzero maybe unnecessary. It can sometimes be redunant, but a common usage pattern puts the ccb_pathinq structure on the stack since it's small and for that scenario, it's required. It's reundant for the few places the ccb is allocated, and in those cases it does no harm. Sponsored by: Netflix Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D51166 --- sys/cam/cam_xpt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/cam/cam_xpt.h b/sys/cam/cam_xpt.h index 06ef52580120..fa4bee97b8f7 100644 --- a/sys/cam/cam_xpt.h +++ b/sys/cam/cam_xpt.h @@ -145,8 +145,8 @@ uint32_t xpt_poll_setup(union ccb *start_ccb); void xpt_sim_poll(struct cam_sim *sim); /* - * Perform a path inquiry at the request priority. The bzero may be - * unnecessary. + * Perform a path inquiry at the request priority. bzero may be redundant for + * allocated CCBs, but for the on-stack CCBs it's required. */ static inline void xpt_path_inq(struct ccb_pathinq *cpi, struct cam_path *path)