Date: Sat, 25 May 2013 13:38:31 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r318993 - in head: archivers/libcabinet archivers/libcabinet/files devel/libpdel devel/libxalloc finance/libstocks games/libshhcards games/libshhcards/files japanese/ming math/linpack w... Message-ID: <20130525113831.GI96836@ithaqua.etoilebsd.net> In-Reply-To: <20130525024802.GD89166@FreeBSD.org> References: <201305241635.r4OGZVa7094499@svn.freebsd.org> <20130525024802.GD89166@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--rPKw41Fi6dB0MaHy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 25, 2013 at 02:48:02AM +0000, Alexey Dokuchaev wrote: > On Fri, May 24, 2013 at 04:35:31PM +0000, Baptiste Daroussin wrote: > > New Revision: 318993 > > URL: http://svnweb.freebsd.org/changeset/ports/318993 > >=20 > > Log: > > Do not let system make.conf inpact the port's makefile > > This fixes build on current > >=20 > > @@ -13,6 +13,7 @@ USE_LDCONFIG=3D yes > > =20 > > SRCFILE=3D ${WRKSRC}/listcab.cpp > > PROGFILE=3D ${SRCFILE:S/.cpp$//} > > +MAKE_ENV=3D WITHOUT_PROFILE=3Dyes __MAKE_CONF=3D/dev/null SRCCONF=3D/d= ev/null >=20 > This looks bogus. Can you shed some light on what exactly breaks these > ports? Can they be fixed without introducing cryptic constructs in their > ports Makefiles? I'd volunteer to fix (when -current gets stable enough > to be feasible for remote upgrade; I don't want to get unbootable box). >=20 > ./danfe I know this looks bogus, but imho this isn't the port should have control o= n own and what things are being built and installed, not a third party file. in that case what is fixed is that if a user set WITH_PROFILE in src.conf a= lib will end up creating and installing a _p.a file, we have the same for .symb= ols, and probably more things. btw: no need to be in current to experience those plist breakage we can still offer the user the same kind of control pn the build process, = but we should to it via the port itself. regards, Bapt --rPKw41Fi6dB0MaHy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGgorcACgkQ8kTtMUmk6Ew35QCfSNFHWyHSoAjoYV4WsdA244ad QAEAnR1Kge5bIfclDaEpMh+jCnOua7Uo =MQuN -----END PGP SIGNATURE----- --rPKw41Fi6dB0MaHy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130525113831.GI96836>