From owner-svn-ports-all@freebsd.org Sat Jul 4 09:17:53 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ECA12366C03; Sat, 4 Jul 2020 09:17:53 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49zR7j643rz4PWP; Sat, 4 Jul 2020 09:17:53 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id CA19C399F; Sat, 4 Jul 2020 09:17:53 +0000 (UTC) Date: Sat, 4 Jul 2020 09:17:53 +0000 From: Alexey Dokuchaev To: Guido Falsi , e@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r541149 - head/net/asterisk13 Message-ID: <20200704091753.GA97282@FreeBSD.org> References: <202007032159.063LxC5m009435@repo.freebsd.org> <20200704051704.GA32566@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jul 2020 09:17:54 -0000 On Sat, Jul 04, 2020 at 10:59:00AM +0200, Guido Falsi wrote: > On 04/07/20 07:17, Alexey Dokuchaev wrote: > > > > Commit logs should also answer the "why" question, not just translate > > the diff to Enligsh. > > I'll add here that sqlite2 library has been abandoned upstream since 2005. > > This fact was pointed out to me in the review at [1], together with the > facts that the asterisk ports are the only ones actually using it. > > Since I agree on removal from the ports tree of obsolete software I > waited for the quarterly branch and then removed the optional dependency. > > sqliteodbc-sqlite2 is going to exp[ire by the end of the month too. Thanks. Now *that* would've made a much better commit log. :-) ./danfe