From owner-dev-commits-ports-main@freebsd.org Fri May 28 19:31:57 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 60BC8630BB0; Fri, 28 May 2021 19:31:57 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FsFDs1k57z4ds9; Fri, 28 May 2021 19:31:57 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1622230317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8lr/pXgj/lODQNFA0N8g7fYyC9WvBkUIgilqWDKc7h0=; b=M9SNtxlj7PuRBQcnA07ViTruWMS0s7fvjH6jG3IL+5+c84t6D/tM/yFy7MmmggJlNua/bg K/3fXrRttjBGLiLx0Gm8v/Y2NArSOEUldcxRbn/BRQXn+H789kWiRwSy9nBWIe7NLRLocR /C0HmuwIiq2FB4zhHNseBdQZ6qgzRZGQJzNzVMUHkuYb/truGVQ16pyetfYPTI7wG08FwY 4SA8pRGYOwUZdBVipwHqnA3P0fDc5oanXi0PvyDgbzM923qGH3yoLr/6mEkF2ehSOsZs2E LJR2SLaUwVp0d/3s0BAkAdrRJqSrDOT8o9OSXp1AfY+ehgtwVQj8Py5k17DYrQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2B4FF1E380; Fri, 28 May 2021 19:31:57 +0000 (UTC) Date: Fri, 28 May 2021 19:31:57 +0000 From: Alexey Dokuchaev To: Joseph Mingrone Cc: Allan Jude , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f45d21ec05cc - main - www/varnish-libvmod-maxminddb: Update to version 1.0.2 Message-ID: References: <202105281835.14SIZNdV086090@gitrepo.freebsd.org> <86tummpstc.fsf@phe.ftfl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86tummpstc.fsf@phe.ftfl.ca> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1622230317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8lr/pXgj/lODQNFA0N8g7fYyC9WvBkUIgilqWDKc7h0=; b=xMhNMc+TjVBWIgeYwMIHBiN3dvxsb4uBYsiandmYPTKyQn9IPkZzZQT3Fn3ljl+oJe/D/e sNGvym5gFpN7y7ibZtYqk3YWI86enQ1xv43kwIZEw5VHr4dDojyF5q/qxNMeEJSE4XNjyN TkQSVboJp52xsLfSfTj9OAgwPn2hzidwfU7zA2SmOYkdLEq1SUfYQ8O40Hsf4pj3sb4cBz nMS8jtdqIvnXwhwJgEO1etfN6lMvg/vURgAG2/QDtmQZRFsnax0wgdP3DtUgsSpCTMORnG e7ha+KQlo8Bx6Y1853FMBsmQoolRxYmcOJ6Ia8KRywCexSxsXFBOs3DALB+dxg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1622230317; a=rsa-sha256; cv=none; b=qZDjrh+uO8OAOWyUc0RAjZJPiPZGydulmSzSp2HHVp81JOPUWGt48FNjwBMdyi/Uzik/0w yYcIgSFG6JdSb0JIx14AvxEDW+LyXcT4GUMU9vNjv6irvapIeeerO34Vfl/J7tQMTLbUIH FhdcIQ6Z7tVwvJOBYM/ysNzJjCGWiE2z1yZhcV8cZz9TTlbxsf+Pv11f0OkdlnEjO+6+ut hNvGnBlza1nD9dlOP+gpjaXd4ueOgkdDTJsDvQknpNf4JC2ncScrGSsEk7qIKZw9ysaVHN mdbFtF913D77reA1TUlqznyxNWn7UZHBAEERwLlbN09ZnBPp+uNA4kgSJGl6UQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2021 19:31:57 -0000 On Fri, May 28, 2021 at 04:22:07PM -0300, Joseph Mingrone wrote: > On Fri, 2021-05-28 at 18:57, Alexey Dokuchaev wrote: > ... > > Can you actually ask for review from someone who has a clue next time? > > > This is by far not the first time I see bogus commit from src guy while > > it has seemingly proper "approved by" attribution in place. I honestly > > don't understand how does it end up like this. > > I think you are blowing things out of proportion. Please look through my > commit history and I think you will generally see careful testing and > very little breakage. Right, that's correct; I admit I deliberately didn't look at who had approved this commit so my reaction won't be biased. Your own commits are fine and you do take proper care Joe. > Alexey, your reaction is hurtful. The next time you make a mistake, I > will make every effort to be more respectful than you. I apologize; I should not have jumped onto this so promptly. I've also violated one of the phk@'s rules of email conduct, neglecting to read entire inbox first. :( ./danfe