From owner-svn-src-all@FreeBSD.ORG Sun Oct 12 13:40:04 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 29228E46; Sun, 12 Oct 2014 13:40:04 +0000 (UTC) Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au [211.29.132.97]) by mx1.freebsd.org (Postfix) with ESMTP id E00B897B; Sun, 12 Oct 2014 13:40:03 +0000 (UTC) Received: from c122-106-147-133.carlnfd1.nsw.optusnet.com.au (c122-106-147-133.carlnfd1.nsw.optusnet.com.au [122.106.147.133]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 4062B780D56; Mon, 13 Oct 2014 00:39:55 +1100 (AEDT) Date: Mon, 13 Oct 2014 00:39:54 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Konstantin Belousov Subject: Re: svn commit: r272952 - in head/sys: fs/ext2fs fs/msdosfs ufs/ffs In-Reply-To: <201410111909.s9BJ9ueU031008@svn.freebsd.org> Message-ID: <20141013003313.G932@besplex.bde.org> References: <201410111909.s9BJ9ueU031008@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=fvDlOjIf c=1 sm=1 tr=0 a=7NqvjVvQucbO2RlWB8PEog==:117 a=PO7r1zJSAAAA:8 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=DsP2KuutBJYMnt7tX9YA:9 a=CjuIK1q_8ugA:10 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Oct 2014 13:40:04 -0000 On Sat, 11 Oct 2014, Konstantin Belousov wrote: > Log: > Do not set IN_ACCESS flag for read-only mounts. The IN_ACCESS > survives remount in rw, also it is set for vnodes on rootfs before > noatime can be set or clock is adjusted. All conditions result in > wrong atime for accessed vnodes. > > Submitted by: bde > MFC after: 1 week Thanks. > ... > Modified: head/sys/ufs/ffs/ffs_vnops.c > ============================================================================== > --- head/sys/ufs/ffs/ffs_vnops.c Sat Oct 11 18:58:58 2014 (r272951) > +++ head/sys/ufs/ffs/ffs_vnops.c Sat Oct 11 19:09:56 2014 (r272952) > @@ -627,7 +627,7 @@ ffs_read(ap) > } > > if ((error == 0 || uio->uio_resid != orig_resid) && > - (vp->v_mount->mnt_flag & MNT_NOATIME) == 0 && > + (vp->v_mount->mnt_flag & (MNT_NOATIME | MNT_RDONLY)) == 0 && > (ip->i_flag & IN_ACCESS) == 0) { > VI_LOCK(vp); > ip->i_flag |= IN_ACCESS; > Is it correct for only ffs to acquire the vnode interlock? I think it is, but don't remember which ffs-only feature requires it. Bruce