From owner-freebsd-ports@FreeBSD.ORG Tue Jan 17 19:41:56 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0B4516A41F; Tue, 17 Jan 2006 19:41:55 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70B6643D48; Tue, 17 Jan 2006 19:41:55 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k0HJfqKp004345; Tue, 17 Jan 2006 11:41:52 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k0HJfpPr004344; Tue, 17 Jan 2006 11:41:51 -0800 Date: Tue, 17 Jan 2006 11:41:51 -0800 From: Brooks Davis To: Pav Lucistnik Message-ID: <20060117194151.GB31908@odin.ac.hmc.edu> References: <200601150911.k0F9B6eG062331@repoman.freebsd.org> <43CC3140.9040604@FreeBSD.org> <8F69821A-31A2-4E2D-A9E9-5CE1BEB2EE1F@brooknet.com.au> <1137494743.38904.41.camel@pav.hide.vol.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UHN/qo2QbUvPLonB" Content-Disposition: inline In-Reply-To: <1137494743.38904.41.camel@pav.hide.vol.cz> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=HTML_MESSAGE autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: ports@freebsd.org, Doug Barton , Sam Lawrance Subject: Re: cvs commit: ports/mail/dk-milter Makefile pkg-plist ports/mail/dk-milter/files milter-dk.sh.in X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2006 19:41:56 -0000 --UHN/qo2QbUvPLonB Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 17, 2006 at 11:45:43AM +0100, Pav Lucistnik wrote: > Sam Lawrance p=ED?e v =FAt 17. 01. 2006 v 21:39 +1100: > > Over to ports@ ... > >=20 > > On 17/01/2006, at 10:50 AM, Doug Barton wrote: > >=20 > > > Pav Lucistnik wrote: > > >> pav 2006-01-15 09:11:04 UTC > > >> > > >> FreeBSD ports repository > > >> > > >> Modified files: > > >> mail/dk-milter Makefile pkg-plist > > >> mail/dk-milter/files milter-dk.sh.in > > >> Log: > > >> - Convert RC script to rc_subr > > >> > > >> PR: ports/91595 http://www.FreeBSD.org/cgi/query-=20 > > >> pr.cgi?pr=3D91595 > > >> Submitted by: Hirohisa Yamaguchi > > >> > > >> Revision Changes Path > > >> 1.6 +3 -2 ports/mail/dk-milter/Makefile > > >> 1.2 +43 -48 ports/mail/dk-milter/files/milter-dk.sh.in > > >> 1.2 +0 -1 ports/mail/dk-milter/pkg-plist > > >> > > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/=20 > > >> Makefile.diff?&r1=3D1.5&r2=3D1.6&f=3Dh > > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/files/=20 > > >> milter-dk.sh.in.diff?&r1=3D1.1&r2=3D1.2&f=3Dh > > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/pkg-=20 > > >> plist.diff?&r1=3D1.1&r2=3D1.2&f=3Dh > > > > > > It's not a big enough issue to warrant a change for this port, but in > > > general it's a good idea if the name of the rc.d file is the same =20 > > > as what > > > the script PROVIDE's. This removes one potential source of =20 > > > confusion for users. > >=20 > > Is it worth a patch to portlint? There are probably a stack of other = =20 > > rc-related things that could be checked for, too. For example, if an = =20 > > rc script is in the packing list, warn to use USE_RC_SUBR. Others? >=20 > If an rc.d script is in the packing list! Old styled scripts are not > affected. How will you check that from portlint? You use grep to see if they match the rules currently used in /etc/rc and /etc/rc/localpkg. Any file which is not an rc.d script, should generate a warning because we plan to fully remove support for old style scripts and non-execution of .sample scripts at some time in the future (my guess would be 8.0). Portlint should also warn about any .sh scripts installed into rc.d since their behavior will change to being sourced with ".