From owner-freebsd-net@FreeBSD.ORG  Sat Jul  2 13:02:47 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id A994B1065673
	for <freebsd-net@freebsd.org>; Sat,  2 Jul 2011 13:02:47 +0000 (UTC)
	(envelope-from cperciva@freebsd.org)
Received: from xps.daemonology.net (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx2.freebsd.org (Postfix) with SMTP id 5E5751530AB
	for <freebsd-net@freebsd.org>; Sat,  2 Jul 2011 13:02:47 +0000 (UTC)
Received: (qmail 10907 invoked from network); 2 Jul 2011 13:02:47 -0000
Received: from unknown (HELO xps.daemonology.net) (127.0.0.1)
	by localhost with SMTP; 2 Jul 2011 13:02:47 -0000
Message-ID: <4E0F16F6.9090903@freebsd.org>
Date: Sat, 02 Jul 2011 06:02:46 -0700
From: Colin Percival <cperciva@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.1.16) Gecko/20101220 Thunderbird/3.0.11
MIME-Version: 1.0
To: freebsd-net@freebsd.org
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: 20+ year old #ifdef notyet in tcp_output.c
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Jul 2011 13:02:47 -0000

Hi all,

In tcp_output.c we have
> #ifdef notyet
> extern struct mbuf *m_copypack();
> #endif
and some time later,
> #ifdef notyet
> 		if ((m = m_copypack(so->so_snd.sb_mb, off,
> 		    (int)len, max_linkhdr + hdrlen)) == 0) {
> 			SOCKBUF_UNLOCK(&so->so_snd);
> 			error = ENOBUFS;
> 			goto out;
> 		}
> 		/*
> 		 * m_copypack left space for our hdr; use it.
> 		 */
> 		m->m_len += hdrlen;
> 		m->m_data -= hdrlen;
> #else
> [snip packet data copying code]
> #endif /* notyet */

These have been around since CVS revision 1.1; going further back, I find this
in "@(#)tcp_output.c        7.22 (Berkeley) 8/31/90" from 4.3BSD Net/2.

Can we agree that this particular notyet isn't going to happen?  I'd like to
remove these lines.

-- 
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid