From owner-cvs-src@FreeBSD.ORG  Tue Nov 28 22:05:35 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DBC7316A47B;
	Tue, 28 Nov 2006 22:05:35 +0000 (UTC)
	(envelope-from ru@rambler-co.ru)
Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5D08E43CC2;
	Tue, 28 Nov 2006 22:05:25 +0000 (GMT)
	(envelope-from ru@rambler-co.ru)
Received: from relay0.rambler.ru (localhost [127.0.0.1])
	by relay0.rambler.ru (Postfix) with ESMTP id 0FC946203;
	Wed, 29 Nov 2006 01:05:29 +0300 (MSK)
Received: from edoofus.park.rambler.ru (unknown [81.19.65.108])
	by relay0.rambler.ru (Postfix) with ESMTP id E17AD61FD;
	Wed, 29 Nov 2006 01:05:28 +0300 (MSK)
Received: (from ru@localhost)
	by edoofus.park.rambler.ru (8.13.8/8.13.8) id kASM5TJd038168;
	Wed, 29 Nov 2006 01:05:29 +0300 (MSK) (envelope-from ru)
Date: Wed, 29 Nov 2006 01:05:29 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Florent Thoumie <flz@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Message-ID: <20061128220529.GA38107@rambler-co.ru>
References: <200611282113.kASLD8vu090754@repoman.freebsd.org>
	<20061128220111.GA71168@tirith.brixandersen.dk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx"
Content-Disposition: inline
In-Reply-To: <20061128220111.GA71168@tirith.brixandersen.dk>
User-Agent: Mutt/1.5.13 (2006-08-11)
X-Virus-Scanned: No virus found
Cc: 
Subject: Re: cvs commit: src/sys/dev/usb ukbd.c usb_quirks.c usb_quirks.h
	usbdevs
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2006 22:05:36 -0000


--dDRMvlgZJXvWKvBx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 28, 2006 at 11:01:11PM +0100, Henrik Brix Andersen wrote:
> On Tue, Nov 28, 2006 at 09:13:08PM +0000, Florent Thoumie wrote:
> > flz         2006-11-28 21:13:08 UTC
> >=20
> >   FreeBSD src repository
> >=20
> >   Modified files:
> >     sys/dev/usb          ukbd.c usb_quirks.c usb_quirks.h usbdevs=20
> >   Log:
> >   Add a quirk for devices recognized as usb keyboards not to be hooked =
by
> >   ukbd(4).
> >  =20
> >   PR:             usb/105669
> >   Submitted by:   Henrik Brix Andersen <henrik@brixandersen.dk>
> >   MFC after:      1 week
>=20
> Thank you for reviewing and committing this patch, much appreciated :)
>=20
> Could you please bump __FreeBSD_version in sys/param.h as well as
> noted in the PR? This will allow checking for proper kernel support in
> my upcoming net-mgmt/wispy-tools port.
>=20
Why can't you just check for the defined constant?


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--dDRMvlgZJXvWKvBx
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFbLKpqRfpzJluFF4RAvmTAJwP5lBI3Cc/fSLBonvJ3iaH11z4BQCgg9i0
gTsabp3A4TEy3Cscrfe4nSI=
=XXxa
-----END PGP SIGNATURE-----

--dDRMvlgZJXvWKvBx--