Date: Mon, 11 May 2015 19:05:00 +0000 From: "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D2377: Introduce ARM GICv3 support Message-ID: <baaa32ffb72337189939b23bdc244048@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org> References: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
emaste added inline comments. INLINE COMMENTS sys/arm64/arm64/gic_v3.c:191 > So now we have to comment on allocation and deallocation? Actually, you could just put a single kassert above at line 140 since we'll already break if rid > INT_MAX on `sc->gic_res[rid] = bus_alloc_resource_any(dev, SYS_RES_MEMORY, ` REVISION DETAIL https://reviews.freebsd.org/D2377 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock Cc: kostikbel, emaste, andrew, imp, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?baaa32ffb72337189939b23bdc244048>