From owner-freebsd-fs@freebsd.org Mon Dec 28 16:06:01 2015 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 705F5A543BF for ; Mon, 28 Dec 2015 16:06:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49BC81180 for ; Mon, 28 Dec 2015 16:06:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tBSG61QZ025777 for ; Mon, 28 Dec 2015 16:06:01 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 205668] [ext2fs] [patch] cannot mount EXT4 filesystems which weren't cleanly unmounted Date: Mon, 28 Dec 2015 16:06:01 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: damjan.jov@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2015 16:06:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205668 Bug ID: 205668 Summary: [ext2fs] [patch] cannot mount EXT4 filesystems which weren't cleanly unmounted Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: damjan.jov@gmail.com CC: freebsd-fs@FreeBSD.org Created attachment 164769 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D164769&action= =3Dedit Patch to add support for the EXT2F_INCOMPAT_RECOVER flag If a disk with the EXT4 filesystem wasn't cleanly unmounted, it will have t= he EXT2F_INCOMPAT_RECOVER flag set on its feature flags, visible as "needs_recovery" in the "Filesystem features" of "tune2fs -l /dev/". Our ext2fs module doesn't know about this flag, and ends up treating a disk= in this state as having unsupported features, logging the inappropriate and confusing message: WARNING: mount of denied due to unsupported optional features to dmesg and unable to mount it until fsck.ext4 even if mounting read-only = or forced. My attached patch adds support for this flag and treats it as supported, warning if the filesystem wasn't cleanly unmounted like it already does with the other 2 ways of marking it as such. --=20 You are receiving this mail because: You are on the CC list for the bug.=