From owner-freebsd-current Tue Nov 23 22:51:13 1999 Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 758) id C154C14D0D; Tue, 23 Nov 1999 22:51:11 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id B32461CD623; Tue, 23 Nov 1999 22:51:11 -0800 (PST) (envelope-from kris@hub.freebsd.org) Date: Tue, 23 Nov 1999 22:51:11 -0800 (PST) From: Kris Kennaway To: David O'Brien Cc: current@freebsd.org Subject: Re: Overflow in banner(1) In-Reply-To: <19991123224424.B51939@dragon.nuxi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 23 Nov 1999, David O'Brien wrote: > On Tue, Nov 23, 1999 at 09:15:35PM -0800, Kris Kennaway wrote: > > - (void)fgets(message, sizeof(message), stdin); > > + (void)fgets(message, MAXMSG, stdin); > > There is nothing wrong with the original line here. Please don't change > things that are fine just to change them. We don't want to ofuscate the fix. Obviously not, but I didn't see the point in making it inconsistent. Kris ---- Cthulhu for President! For when you're tired of choosing the _lesser_ of two evils.. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message