From owner-freebsd-ports@FreeBSD.ORG  Tue Jul 22 13:07:27 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 337F337B401; Tue, 22 Jul 2003 13:07:27 -0700 (PDT)
Received: from saltmine.radix.net (saltmine.radix.net [207.192.128.40])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 47A4143FAF; Tue, 22 Jul 2003 13:07:26 -0700 (PDT)
	(envelope-from dickey@saltmine.radix.net)
Received: from saltmine.radix.net (localhost [127.0.0.1])
	by saltmine.radix.net (8.12.2/8.12.2) with ESMTP id h6MK711o002510;
	Tue, 22 Jul 2003 16:07:25 -0400 (EDT)
Received: (from dickey@localhost)
	by saltmine.radix.net (8.12.2/8.12.2/Submit) id h6MK71fN002509;
	Tue, 22 Jul 2003 16:07:01 -0400 (EDT)
Date: Tue, 22 Jul 2003 16:07:01 -0400
From: Thomas Dickey <dickey@radix.net>
To: "Jacques A. Vidrine" <nectar@freebsd.org>
Message-ID: <20030722200700.GA2013@saltmine.radix.net>
References: <20030718025200.GA36893@rot13.obsecurity.org>
	<20030722122608.GC552@zi025.glhnet.mhn.de>
	<20030722195637.GC10922@madman.celabo.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030722195637.GC10922@madman.celabo.org>
User-Agent: Mutt/1.3.27i
cc: ports@freebsd.org
cc: Simon Barner <barner@in.tum.de>
cc: current@freebsd.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2003 20:07:27 -0000

On Tue, Jul 22, 2003 at 02:56:37PM -0500, Jacques A. Vidrine wrote:
> On Tue, Jul 22, 2003 at 02:26:08PM +0200, Simon Barner wrote:
> 
> > --- plugins/check_by_ssh.c.orig	Mon Apr 23 09:43:11 2001
> > +++ plugins/check_by_ssh.c	Tue Jul 22 05:05:52 2003
> > @@ -191,7 +191,7 @@
> >  	if (commands>1)
> >  		remotecmd=strscat(remotecmd,";echo STATUS CODE: $?;");
> >  
> > -	if (strlen (remotecmd) <= 1)
> > +	if (remotecmd==NULL)
> >  		usage ("No remotecmd\n");
> >  
> >  	comm = ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd);
> 
> This looks like more than a fix for a `compile failure'.  The
> replacement code has different semantics than the new code.
> What is the `compile failure' that was being fixed here?

perhaps the compiler was pointing out that remotecmd may not be initialized.

(I don't see enough context to be sure ;-)

-- 
Thomas E. Dickey <dickey@radix.net> <dickey@herndon4.his.com>
http://dickey.his.com
ftp://dickey.his.com