Date: Fri, 4 Jan 2019 00:23:15 +0100 From: Tobias Kortkamp <tobik@freebsd.org> To: Sean Bruno <sbruno@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest Message-ID: <20190103232315.GA10712@urd.tobik.me> In-Reply-To: <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 03, 2019 at 03:30:44PM -0700, Sean Bruno wrote: >=20 >=20 > On 1/3/19 2:54 PM, Tobias Kortkamp wrote: > >> +USE_QT=3D buildtools \ > > Does clementine-player, a music player, really need qt5-buildtools > > at runtime or should this be buildtools_build instead? > >=20 > >> + concurrent \ > >> + core \ > >> dbus \ > >> gui \ > >> imageformats \ > >> - qmake_build \ > >> linguist_build \ > >> - moc_build \ > >> network \ > >> opengl \ > >> - qtestlib \ > >> - rcc_build \ > >> + qmake_build \ > >> + testlib \ > > Same here. Does it really need qt5-testlib at runtime? > >=20 >=20 > Probably not? >=20 > sean >=20 So I guess they are not needed at runtime. Will you change them to build dependencies? There is another more severe problem. The version goes backwards, so users will never receive this update. $ pkg version -t 1.3.1.g20190103 1.3.1.441_7 < --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlwumWBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2GMzQgApbus/jm29DGicl8UJQ+fd5HlouIdG7aILvMhA/smHIFtSh8qwmoD5MHa 8TzCpxhAEbLKGVK5FCLl7hIHyqyA9KG3xDDkbGMcVno3XrOiCWvGV29jE6o7tHsr TWwiwhUzVFtkoYZO4peQQLzOcSXsRf2+fUXRgarC8YntY9pGRhcfA1xGreEseGFE v6ayFl3+90St48E7qwV2m2Ypsch63ZskEv3oXE1tDvYsTepLcug6BMrQvrTaZUbf ntVzTNIpjpANblOYApv3H2pVNSUX5QBgo/Tc+tD2PPYxOOiSHGsoVPgO5Dnl1xNP GLDcKBuH01UJNy0cBrn5ZVk5mKR1iQ== =Hkfh -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190103232315.GA10712>