From owner-svn-ports-head@FreeBSD.ORG Fri Mar 22 15:15:50 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 1E47983A; Fri, 22 Mar 2013 15:15:50 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-ea0-x22f.google.com (mail-ea0-x22f.google.com [IPv6:2a00:1450:4013:c01::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 379945E5; Fri, 22 Mar 2013 15:15:49 +0000 (UTC) Received: by mail-ea0-f175.google.com with SMTP id o10so1416713eaj.6 for ; Fri, 22 Mar 2013 08:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=LcoXTUvRJbmyYA04gnvk5Fk8WFT6eM1eAICypSogtIo=; b=s3hnCXZzj+jUKi6MbsE3vPmrDR0kxBY6nyiqjP2TnwyOj2IseDfvxcO2buQ6ugsMvV +ZFn2xkw1bIqCY79KcOpfhZqIJxP/xX8wjOWhNpBASCmO2LPmpAyPRSmTwHsdPtKWqVC 3VgmvwSpzRp71nOpHW3K3QxRmQTRqkOawrJHZ5FjyEb0L4I+p4bk50FaVv0EzuXpqjNw 6zT9zJ4cvetP50uGfu8te0YnLLSEm0d/YFQ8B2IBZEmllJskpEDtfHwcdhnlopkQuVjj sNjFwD8Olrc97shZg4GJmNJ0Z9/79/g+VaWJcnS1P9+B5H54b3OqcVQC9zZzYwckrLrD Gnbw== X-Received: by 10.14.183.198 with SMTP id q46mr6227122eem.1.1363965348304; Fri, 22 Mar 2013 08:15:48 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id q5sm3564995eep.11.2013.03.22.08.15.46 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 22 Mar 2013 08:15:47 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 22 Mar 2013 16:15:45 +0100 From: Baptiste Daroussin To: Boris Samorodov Subject: Re: svn commit: r314859 - head/palm/jpilot Message-ID: <20130322151545.GB14206@ithaqua.etoilebsd.net> References: <201303211827.r2LIRHrh078301@svn.freebsd.org> <514C6DEF.10201@passap.ru> <20130322145344.GA16844@FreeBSD.org> <514C735F.1050005@passap.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QTprm0S8XgL7H0Dt" Content-Disposition: inline In-Reply-To: <514C735F.1050005@passap.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2013 15:15:50 -0000 --QTprm0S8XgL7H0Dt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 22, 2013 at 07:06:07PM +0400, Boris Samorodov wrote: > 22.03.2013 18:53, Alexey Dokuchaev =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote: > >> 21.03.2013 22:27, Baptiste Daroussin =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >>> --- head/palm/jpilot/Makefile Thu Mar 21 18:25:04 2013 (r314858) > >>> +++ head/palm/jpilot/Makefile Thu Mar 21 18:27:17 2013 (r314859) > >> [...] > >>> -# "?=3D" and "+=3D" are for including this Makefile from japanese/jp= ilot > >> > >> Not particular to this commit, but rather a general question: > >> what is our current policy on comments at the makefile headers? > >> I mean non-standard comments (maintainer tips, etc.). Should > >> they be deleted? > >=20 > > I would not delete them (in general case). >=20 > ACK. >=20 > > In this particular case I assume > > they were deleted because they were stating quite obvious thing: certain > > variables with +=3D/?=3D are clear indication of master/slave relations= hip. >=20 > Unfortunately our standard tool makes this: > ----- > bsam% cd /usr/ports/palm/jpilot >=20 > bsam% grep ^# Makefile > # Created by: Alex Varju > # $FreeBSD: head/palm/jpilot/Makefile 314859 2013-03-21 18:27:17Z bapt $ > # Do not edit this makefile header!!! >=20 > bsam% /usr/ports/Tools/scripts/convert-makefile-header.pl > ./Makefile converted >=20 > bsam% grep ^# Makefile > # Created by: Alex Varju > # $FreeBSD$ > ----- That is how I get doomed. iirc just add an empty line between standards hea= ders and "specific" one and the tool will not nuked them. regards, Bapt --QTprm0S8XgL7H0Dt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFMdaEACgkQ8kTtMUmk6EwySwCcDg4YEKKlIS1r1C53gwDJi+ZS M40Anj8rjC65Gb51QTUi2SRePul++4ff =tuVk -----END PGP SIGNATURE----- --QTprm0S8XgL7H0Dt--