From owner-cvs-all@FreeBSD.ORG  Mon Dec  3 23:37:15 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5EB0B16A417;
	Mon,  3 Dec 2007 23:37:15 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219])
	by mx1.freebsd.org (Postfix) with ESMTP id BB4E713C4D1;
	Mon,  3 Dec 2007 23:37:14 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (unverified [66.23.211.162]) 
	by speedfactory.net (SurgeMail 3.8p) with ESMTP id 222510522-1834499 
	for multiple; Mon, 03 Dec 2007 18:37:20 -0500
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id lB3Nb5Vt087605;
	Mon, 3 Dec 2007 18:37:06 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Dag-Erling =?utf-8?q?Sm=C3=B8rgrav?= <des@des.no>
Date: Mon, 3 Dec 2007 16:57:33 -0500
User-Agent: KMail/1.9.6
References: <200711232356.lANNu3mp040885@repoman.freebsd.org>
	<864pezer7f.fsf@ds4.des.no>
In-Reply-To: <864pezer7f.fsf@ds4.des.no>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200712031657.34074.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Mon, 03 Dec 2007 18:37:06 -0500 (EST)
X-Virus-Scanned: ClamAV 0.91.2/4985/Mon Dec 3 15:50:32 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: cvs-src@freebsd.org, John Birrell <jb@freebsd.org>,
	src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/netinet/libalias alias_util.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2007 23:37:15 -0000

On Monday 03 December 2007 10:24:52 am Dag-Erling Sm=C3=B8rgrav wrote:
> John Birrell <jb@FreeBSD.org> writes:
> >   Log:
> >   Fix strict alias warnings.
>=20
> A much simpler solution (relative to the previous revision):
>=20
> @@ -131,10 +131,10 @@
>                 sum +=3D oddbyte;
>         }
>  /* "Pseudo-header" data */
> -       ptr =3D (u_short *) & (pip->ip_dst);
> +       ptr =3D (void *)&pip->ip_dst;
>         sum +=3D *ptr++;
>         sum +=3D *ptr;
> -       ptr =3D (u_short *) & (pip->ip_src);
> +       ptr =3D (void *)&pip->ip_src;
>         sum +=3D *ptr++;
>         sum +=3D *ptr;
>         sum +=3D htons((u_short) ntcp);

*ptr++ would choke since pointer arith on (void *) is undefined AFAIK.

=2D-=20
John Baldwin