From owner-cvs-src@FreeBSD.ORG Wed Jun 4 20:12:58 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 533E91065675; Wed, 4 Jun 2008 20:12:58 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from websrv01.jr-hosting.nl (websrv01.jr-hosting.nl [78.47.69.233]) by mx1.freebsd.org (Postfix) with ESMTP id ECE588FC1E; Wed, 4 Jun 2008 20:12:57 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from [195.64.94.120] (helo=[10.0.2.148]) by websrv01.jr-hosting.nl with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69 (FreeBSD)) (envelope-from ) id 1K3zOM-000H7R-GS; Wed, 04 Jun 2008 22:15:30 +0200 Message-ID: <4846F743.3040903@FreeBSD.org> Date: Wed, 04 Jun 2008 22:12:51 +0200 From: Remko Lodder User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: Maxim Sobolev References: <200805301426.m4UEQ92d025434@repoman.freebsd.org> <48405C4B.3050603@FreeBSD.org> <1212179252.1967.1.camel@localhost> <20080604041815.GA84027@FreeBSD.org> <20080604043955.GA38627@troutmask.apl.washington.edu> <20080604063631.GA28351@freebie.xs4all.nl> <20080604150013.GA44358@troutmask.apl.washington.edu> <20080604191339.GA31570@freebie.xs4all.nl> <20080604192955.GA46284@troutmask.apl.washington.edu> <4846EF10.1020803@FreeBSD.org> <4846F30A.5070204@FreeBSD.org> In-Reply-To: <4846F30A.5070204@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexey Dokuchaev , src-committers@FreeBSD.org, Florent Thoumie , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Steve Kargl , Wilko Bulte , Coleman Kane Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c pkg_add.1 src/usr.sbin/pkg_install/create main.c pkg_create.1 src/usr.sbin/pkg_install/delete main.c pkg_delete.1 src/usr.sbin/pkg_install/info main.c pkg_info.1 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 20:12:58 -0000 Maxim Sobolev wrote: > Remko Lodder wrote: >>> Where do we stop? Should we add long options to all >>> /usr/bin utilities? Why stop at /usr/bin, let's add >>> long options to /usr/sbin, /bin, /sbin, /rescue, etc. >>> >> >> That is not your call. If a maintainer wants to add all options he can >> consider, he is free to do so. Though others might not appreciate that >> as much as he does. It can be discussed ofcourse, but to a certain >> extend. > > It's not your call either. We have style(9), which says: > > For consistency, getopt(3) should be used to parse options. Options > should be sorted in the getopt(3) call and the switch statement, > unless > parts of the switch cascade. Elements in a switch statement that > cascade > should have a FALLTHROUGH comment. Numerical arguments should be > checked > for accuracy. Code that cannot be reached should have a NOTREACHED > com- > ment. > > There is nothing about getopt_long(3) being acceptable > replacement/addition to the getopt(3). > getopt(3) is implemented, and it's expanded by getopt_long(3) in this case. The requirement is fullfilled and made more readable (in my eyes) then before. Not everyone agrees, too bad, the world is not perfect :-). (I'll end discussing this with this email). Cheers, remko -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News