From owner-svn-src-head@FreeBSD.ORG Mon May 28 20:49:35 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BCD02106566B; Mon, 28 May 2012 20:49:35 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 347E88FC18; Mon, 28 May 2012 20:49:34 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q4SKnVRm071445; Mon, 28 May 2012 23:49:31 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q4SKnUne026694; Mon, 28 May 2012 23:49:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q4SKnUoH026693; Mon, 28 May 2012 23:49:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 28 May 2012 23:49:30 +0300 From: Konstantin Belousov To: David Chisnall Message-ID: <20120528204930.GE2358@deviant.kiev.zoral.com.ua> References: <201205270527.q4R5Rm44028055@svn.freebsd.org> <20120527203100.GA22921@freebsd.org> <4FC3D320.1070709@FreeBSD.org> <944B5ADD-8F3C-4CE4-BF97-36964F4EBB64@theravensnest.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="20f69GCBTQuZN9jn" Content-Disposition: inline In-Reply-To: <944B5ADD-8F3C-4CE4-BF97-36964F4EBB64@theravensnest.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, Roman Divacky , src-committers@freebsd.org, Dimitry Andric , svn-src-all@freebsd.org Subject: Re: svn commit: r236137 - head/contrib/gcc/config/i386 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2012 20:49:35 -0000 --20f69GCBTQuZN9jn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 28, 2012 at 09:17:23PM +0100, David Chisnall wrote: > On 28 May 2012, at 20:33, Dimitry Andric wrote: >=20 > > On the other hand, it's really platform-dependent: I've checked several > > Linux distributions, and it is fairly unpredictable whether their gcc > > passes --hash-style to the linker, or if they do, which option they use. >=20 > Can we make it dependent on the triple? i.e. if the triple is > arch-whatever-freebsd9 or greater, make it pass the flag, otherwise > don't bother? Or is it not worth caring about older FreeBSD? There's > no real disadvantage in passing it unconditionally (marginally longer > link times) and potentially a big benefit. I don't see a problem with > committing it upstream, but it would be nice to pull that change in > locally before 9.1 and not have to wait for LLVM 3.2 before we got to > make use of it. Having unused hash in the image causes on-disk bloat. Since hashes are merged into text segments (they are needed by rtld and so are mapped), this also causes memory use bloat. It is definitely not huge, at least not for normal binaries with reasonably sized symbol table. Also, it is more work for the linker to generate both tables. > > Misleading and poorly designed benchmarks on Phoronix are at stake! > > David --20f69GCBTQuZN9jn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk/D5NoACgkQC3+MBN1Mb4jlgACbBlxKOPl/878jBnNHsCqYOsGZ ClAAn08fCvp9ESJ6DchwpEBe4/Gj++F/ =PjzJ -----END PGP SIGNATURE----- --20f69GCBTQuZN9jn--