Date: Mon, 28 May 2012 23:49:30 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: David Chisnall <theraven@theravensnest.org> Cc: svn-src-head@freebsd.org, Roman Divacky <rdivacky@freebsd.org>, src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org>, svn-src-all@freebsd.org Subject: Re: svn commit: r236137 - head/contrib/gcc/config/i386 Message-ID: <20120528204930.GE2358@deviant.kiev.zoral.com.ua> In-Reply-To: <944B5ADD-8F3C-4CE4-BF97-36964F4EBB64@theravensnest.org> References: <201205270527.q4R5Rm44028055@svn.freebsd.org> <20120527203100.GA22921@freebsd.org> <4FC3D320.1070709@FreeBSD.org> <944B5ADD-8F3C-4CE4-BF97-36964F4EBB64@theravensnest.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--20f69GCBTQuZN9jn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 28, 2012 at 09:17:23PM +0100, David Chisnall wrote: > On 28 May 2012, at 20:33, Dimitry Andric wrote: >=20 > > On the other hand, it's really platform-dependent: I've checked several > > Linux distributions, and it is fairly unpredictable whether their gcc > > passes --hash-style to the linker, or if they do, which option they use. >=20 > Can we make it dependent on the triple? i.e. if the triple is > arch-whatever-freebsd9 or greater, make it pass the flag, otherwise > don't bother? Or is it not worth caring about older FreeBSD? There's > no real disadvantage in passing it unconditionally (marginally longer > link times) and potentially a big benefit. I don't see a problem with > committing it upstream, but it would be nice to pull that change in > locally before 9.1 and not have to wait for LLVM 3.2 before we got to > make use of it. Having unused hash in the image causes on-disk bloat. Since hashes are merged into text segments (they are needed by rtld and so are mapped), this also causes memory use bloat. It is definitely not huge, at least not for normal binaries with reasonably sized symbol table. Also, it is more work for the linker to generate both tables. > > Misleading and poorly designed benchmarks on Phoronix are at stake! > > David --20f69GCBTQuZN9jn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk/D5NoACgkQC3+MBN1Mb4jlgACbBlxKOPl/878jBnNHsCqYOsGZ ClAAn08fCvp9ESJ6DchwpEBe4/Gj++F/ =PjzJ -----END PGP SIGNATURE----- --20f69GCBTQuZN9jn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120528204930.GE2358>