Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Aug 2023 14:15:59 GMT
From:      Fernando =?utf-8?Q?Apestegu=C3=ADa?= <fernape@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: ec06aff4d882 - main - devel/valgrind-devel: do not strip binaries
Message-ID:  <202308221415.37MEFxgX003780@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by fernape:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ec06aff4d8821e97187ed86918f0225ad59661d4

commit ec06aff4d8821e97187ed86918f0225ad59661d4
Author:     Paul Floyd <pjfloyd@wanadoo.fr>
AuthorDate: 2023-08-22 07:05:46 +0000
Commit:     Fernando ApesteguĂ­a <fernape@FreeBSD.org>
CommitDate: 2023-08-22 14:15:36 +0000

    devel/valgrind-devel: do not strip binaries
    
    Valgrind binaries should not be stripped (at least, not the preload shared
    libs).
    
    PR:             273243
    Reported by:    pjfloyd@wanadoo.fr (maintainer)
---
 devel/valgrind-devel/Makefile | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/devel/valgrind-devel/Makefile b/devel/valgrind-devel/Makefile
index c390556c2d69..35bbe0227cce 100644
--- a/devel/valgrind-devel/Makefile
+++ b/devel/valgrind-devel/Makefile
@@ -1,5 +1,6 @@
 PORTNAME=	valgrind
 PORTVERSION=	3.21.0.g20230218
+PORTREVISION=	1
 DISTVERSIONPREFIX=	freebsd-
 PORTEPOCH=	1
 CATEGORIES=	devel
@@ -28,6 +29,15 @@ SSP_UNSAFE=	yes
 LIB32_PATH?=	/usr/lib32/libc.so
 
 CONFLICTS=	valgrind
+
+# Valgrind needs to read debuginfo from its own preload shared libraries
+# (quote from README_PACKAGERS
+#-- Don't strip the debug info off lib/valgrind/$platform/vgpreload*.so
+#   in the installation tree.  Either Valgrind won't work at all, or it
+#   will still work if you do, but will generate less helpful error
+#   messages.)
+STRIP=          # empty
+
 PORTDOCS=	html
 
 OPTIONS_DEFINE=		DOCS MANPAGES MPI



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308221415.37MEFxgX003780>