From owner-cvs-all  Wed Mar 15  3:52:54 2000
Delivered-To: cvs-all@freebsd.org
Received: from freebsd.dk (freebsd.dk [212.242.42.178])
	by hub.freebsd.org (Postfix) with ESMTP
	id 96ABA37B9B7; Wed, 15 Mar 2000 03:52:48 -0800 (PST)
	(envelope-from sos@freebsd.dk)
Received: (from sos@localhost)
	by freebsd.dk (8.9.3/8.9.1) id MAA70295;
	Wed, 15 Mar 2000 12:52:46 +0100 (CET)
	(envelope-from sos)
From: Soren Schmidt <sos@freebsd.dk>
Message-Id: <200003151152.MAA70295@freebsd.dk>
Subject: Re: cvs commit: src/sys/boot/i386/libi386 biosdisk.c
In-Reply-To: <200003150158.RAA46696@freefall.freebsd.org> from "Daniel C. Sobral" at "Mar 14, 2000 05:58:46 pm"
To: dcs@FreeBSD.org (Daniel C. Sobral)
Date: Wed, 15 Mar 2000 12:52:46 +0100 (CET)
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

It seems Daniel C. Sobral wrote:
> dcs         2000/03/14 17:58:46 PST
> 
>   Modified files:
>     sys/boot/i386/libi386 biosdisk.c 
>   Log:
>   Pass an unit number to bcache_strategy, so it can flush the cache when
>   necessary. Pass an absolute block number too, instead of receiving a
>   relative one in realstrategy(), as bcache_strategy() requires this.
>   
>   The fix is sligthly different from the one in the PR.

You could have tested it before committing it, it looks totally bogus:

cc -O -pipe -I/u1/src/sys/boot/i386/libi386/../../common -I/u1/src/sys/boot/i386/libi386/../btx/lib  -I/u1/src/sys/boot/i386/libi386/../../.. -I. -DCOMPORT=0x3f8 -DCOMSPEED=9600 -DTERM_EMU -c /u1/src/sys/boot/i386/libi386/biosdisk.c -o biosdisk.o
/u1/src/sys/boot/i386/libi386/biosdisk.c: In function `bd_print':
/u1/src/sys/boot/i386/libi386/biosdisk.c:242: syntax error before `,'
/u1/src/sys/boot/i386/libi386/biosdisk.c:289: case label not within a switch statement
/u1/src/sys/boot/i386/libi386/biosdisk.c:293: default label not within a switch statement
/u1/src/sys/boot/i386/libi386/biosdisk.c: At top level:
/u1/src/sys/boot/i386/libi386/biosdisk.c:301: syntax error before `}'
..
..

-Søren


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message