From owner-cvs-all Mon Jan 18 20:09:46 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA06493 for cvs-all-outgoing; Mon, 18 Jan 1999 20:09:46 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from zippy.dyn.ml.org (libya-202.ppp.hooked.net [206.169.227.202]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA06487; Mon, 18 Jan 1999 20:09:43 -0800 (PST) (envelope-from garbanzo@hooked.net) Received: from localhost (garbanzo@zippy.dyn.ml.org [127.0.0.1]) by zippy.dyn.ml.org (8.9.1/8.8.8) with ESMTP id UAA03045; Mon, 18 Jan 1999 20:12:58 -0800 (PST) (envelope-from garbanzo@hooked.net) Date: Mon, 18 Jan 1999 20:12:57 -0800 (PST) From: Alex Zepeda X-Sender: garbanzo@zippy.dyn.ml.org To: Joseph Koshy cc: Sheldon Hearn , cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/audio/mpg123/patches patch-aa In-Reply-To: <199901190404.UAA06099@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Mon, 18 Jan 1999, Joseph Koshy wrote: > By moving CFLAGS to the end we can handle this simple case, but the > approach doesn't go very far. You can't always turn off an option that > came earlier on the command line. Like what? -ffoo can usually be turned off with -fnofoo. The only thing that immediately comes to mind is setjmp/longjmp exceptions. Why not test to see if the user has already set CFLAGS/CC (and C++ counterparts), and warn them if they have, but still use them. (CC ?= cc , etc, etc). > Some ports really need the best optimization that the compiler can > offer (-O6) and and the default optimization in /etc/make.conf will > probably be too low for these. Cranking up the -O levels in the > /etc/make.conf will however cause the system to display > ``interesting'' symptoms after the next `make world'. > > For these and other reasons IMHO the scope of `customizability' via CFLAGS > and its ilk shouldn't be too large. Folks should be required to edit > Makefiles if they want sophisticated stuff :). - alex | "Contrary to popular belief, penguins are not the salvation of modern | | technology. Neither do they throw parties for the urban proletariat." | | Powered by FreeBSD http://www.freebsd.org/ | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message