From owner-svn-src-head@FreeBSD.ORG Wed Apr 21 05:10:54 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46F2A106566C; Wed, 21 Apr 2010 05:10:54 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id 162868FC16; Wed, 21 Apr 2010 05:10:53 +0000 (UTC) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id 772ED2C2AEB; Wed, 21 Apr 2010 00:10:53 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sWxE+yQNxR-m; Wed, 21 Apr 2010 00:10:45 -0500 (CDT) Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id 194302C2A92; Wed, 21 Apr 2010 00:10:45 -0500 (CDT) Message-ID: <4BCE88D4.5080600@cs.rice.edu> Date: Wed, 21 Apr 2010 00:10:44 -0500 From: Alan Cox User-Agent: Thunderbird 2.0.0.24 (X11/20100327) MIME-Version: 1.0 To: Peter Jeremy References: <201004182129.o3ILTSCd098832@svn.freebsd.org> <20100420205845.GA38549@server.vk2pj.dyndns.org> In-Reply-To: <20100420205845.GA38549@server.vk2pj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alan Cox , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r206814 - head/sys/vm X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2010 05:10:54 -0000 Peter Jeremy wrote: > On 2010-Apr-18 21:29:28 +0000, Alan Cox wrote: > >> Remove a nonsensical test from vm_pageout_clean(). A page can't be in the >> inactive queue and have a non-zero wire count. >> > > Should this test be turned into a KASSERT()? > > I considered it, but no I don't think an assertion is called for. We already have checks in the places where a page is wired or unwired. Regards, Alan