From owner-freebsd-hackers Thu Jan 12 07:34:21 1995 Return-Path: hackers-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.9/8.6.6) id HAA23636 for hackers-outgoing; Thu, 12 Jan 1995 07:34:21 -0800 Received: from skynet.ctr.columbia.edu (skynet.ctr.columbia.edu [128.59.64.70]) by freefall.cdrom.com (8.6.9/8.6.6) with ESMTP id HAA23630 for ; Thu, 12 Jan 1995 07:34:18 -0800 Received: (from wpaul@localhost) by skynet.ctr.columbia.edu (8.6.8/8.6.6) id KAA02843 for freebsd-hackers@freebsd.org; Thu, 12 Jan 1995 10:32:15 -0500 From: Wankle Rotary Engine Message-Id: <199501121532.KAA02843@skynet.ctr.columbia.edu> Subject: Small syscons change To: freebsd-hackers@FreeBSD.org Date: Thu, 12 Jan 1995 10:32:10 -0500 (EST) X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 1920 Sender: hackers-owner@FreeBSD.org Precedence: bulk After some discussion with Bruce Evans, I've decided to submit the following tiny patch for /sys/i386/isa/syscons.c: *** syscons.c.orig Thu Jan 12 09:52:45 1995 --- syscons.c Thu Jan 12 09:53:13 1995 *************** *** 2100,2110 **** /* Print only printables */ *scp->crtat = (scp->term.cur_attr | scr_map[c]); scp->crtat++; ! /* ! * Wrap at the *LAST* column, not the last column ! * minus one!!!! Arrrghhh!!! ! */ ! if (++scp->xpos > /* = */ scp->xsize) { scp->xpos = 0; scp->ypos++; } --- 2100,2106 ---- /* Print only printables */ *scp->crtat = (scp->term.cur_attr | scr_map[c]); scp->crtat++; ! if (++scp->xpos >= scp->xsize) { scp->xpos = 0; scp->ypos++; } This patch backs out the 'cursor wraps at wrong place' fix I had bundled in with my NOBLINK_CURSOR mods. Apparently this change breaks elvis and bash (although bash's problems appear to be bash's own fault -- this is version 1.14.2 we're talking about here). The NOBLINK_CURSOR mods don't seem to be a problem. (They better not be. :) I made this change originally to avoid some trouble I was having with a VAX that steadfastly insisted on wrapping at the wrong place when using ANSI terminal mode (SET TERM/DEV=UNKNOWN/ANSI). I guess what's good for the VAX isn't good for everyone else. If anyone else has noticed problems with this, please speak up. -Bill -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~T~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Bill Paul (212) 854-6020 | System Manager Work: wpaul@ctr.columbia.edu | Center for Telecommunications Research Home: wpaul@skynet.ctr.columbia.edu | Columbia University, New York City ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The Møøse Illuminati: ignore it and be confused, or join it and be confusing! ~~~~~~~~ FreeBSD 2.1.0-Development #0: Mon Jan 9 14:59:33 EST 1995 ~~~~~~~~~