Date: Mon, 22 Apr 2013 20:31:18 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Jilles Tjoelker <jilles@stack.nl> Cc: freebsd-hackers@freebsd.org Subject: Re: [patch] pipe2 Message-ID: <20130422173118.GQ67273@kib.kiev.ua> In-Reply-To: <20130421210243.GA10436@stack.nl> References: <20130419224839.GA69212@stack.nl> <20130421210243.GA10436@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--ngPZezdD7QsvFaqQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 21, 2013 at 11:02:43PM +0200, Jilles Tjoelker wrote: > On Sat, Apr 20, 2013 at 12:48:39AM +0200, Jilles Tjoelker wrote: > > I'm also working on pipe2() (using linuxulator work) and dup3() (patch > > from Jukka A. Ukkonen). >=20 > This is an implementation of pipe2. As with the accept4 patch, make > sysent needs to be run in sys/kern and sys/compat/freebsd32. >=20 > As a bonus, new architectures might implement pipe(p) as pipe2(p, 0) > avoiding the need for assembler (but behaviour is different if the > pointer is invalid). I do not see anything wrong with the patch. That said, I prefer the pipe(2) approach of delegating the access to the usermode memory to usermode, which avoids the need of the calls to kern_close(). --ngPZezdD7QsvFaqQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRdXPlAAoJEJDCuSvBvK1B+B8P/RgbZEipYkGxEyqHwsL4sglx J/tspDO8mx+SZN0xS4zYBggt/APsZWlRiEWdLPvVi2y0C3ZdckKFR1eY0pNIcJ3J SDGO5MmW757jXnRHWvjD5Y6RTPOIP5dfaCOCK8des/YStTyHTZoDAlwTRnIE9S2c h04uianGAiDfcSKNNKG6KVVFFUXoDEkP5o/CcIMyqNWyfJZ4CKQIxbObtcBU1uy7 FZCNVpNY/qVFW5V3Hu8AfrBkv4xe/yyKhar5NuQV5EYbA3Kl6rTGrpPgxEIpHDkC xSULMfYk+sXzYls0NCQh+Ymr7FoCxhlQmuWxBkuw5B68rzC+HN+iH0Sxgy1juJ1B rNzumE0M6NOvHPfZLFYoNACl6IBou4mJ+Dqi1z69iJkNGjqjAD/xOczDF9Yqz+d6 hgpr4HZ+6umatPbzn5FWw9Uk3rXg1eW/dtGTnlfuClca55y4iWBZT/H3Po8dTrb+ 8tH3TCyxusOzP4pCQ0ObqYO03OQWE5qQV/E0VTPWCHgrTWSddJ4AM6yx5WDpji/i iOjSls4UDFA6diGlLWhaHCtT3al+Ftf3XFVIPJOX7qdqP69b2IwXYqKLrsfyBgB7 YDXW1qKSpHUNOmhsB3qecMHW/rP/LyWjMhqWLC5QPbM46c1KZkHuHoMIEbW38qCu lnLwiZgEE5perqqdDBiX =uFnG -----END PGP SIGNATURE----- --ngPZezdD7QsvFaqQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130422173118.GQ67273>