From owner-freebsd-fs@FreeBSD.ORG  Wed Feb 21 14:40:04 2007
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
X-Original-To: freebsd-fs@freebsd.org
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 642DB16DF1F
	for <freebsd-fs@freebsd.org>; Wed, 21 Feb 2007 14:40:04 +0000 (UTC)
	(envelope-from anderson@freebsd.org)
Received: from mh1.centtech.com (moat3.centtech.com [64.129.166.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 334ED13C4B2
	for <freebsd-fs@freebsd.org>; Wed, 21 Feb 2007 14:40:04 +0000 (UTC)
	(envelope-from anderson@freebsd.org)
Received: from [10.177.171.220] (neutrino.centtech.com [10.177.171.220])
	by mh1.centtech.com (8.13.8/8.13.8) with ESMTP id l1LEduBk095562;
	Wed, 21 Feb 2007 08:39:56 -0600 (CST)
	(envelope-from anderson@freebsd.org)
Message-ID: <45DC59C0.8080206@freebsd.org>
Date: Wed, 21 Feb 2007 08:40:00 -0600
From: Eric Anderson <anderson@freebsd.org>
User-Agent: Thunderbird 1.5.0.9 (X11/20070204)
MIME-Version: 1.0
To: Alexey Karakuts <sys@bsdportal.ru>
References: <4d3557900702210155n2f57761fl6b8b4df500a1cf77@mail.gmail.com>
In-Reply-To: <4d3557900702210155n2f57761fl6b8b4df500a1cf77@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV 0.88.4/2617/Wed Feb 21 05:38:25 2007 on
	mh1.centtech.com
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.6 required=8.0 tests=BAYES_00 autolearn=ham 
	version=3.1.6
X-Spam-Checker-Version: SpamAssassin 3.1.6 (2006-10-03) on mh1.centtech.com
Cc: freebsd-fs@freebsd.org
Subject: Re: The patch delete no umount eject flash disk freebsd panic
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Feb 2007 14:40:04 -0000

On 02/21/07 03:55, Alexey Karakuts wrote:
>  #The patch delete flash disk freebsd panic
> #Any questions send email sys@bsdportal.ru Alexey N. Karakuts
> --- /sys/geom/geom_vfs.c        Mon Mar 13 03:05:29 2006
> +++ geom_vfs.c  Wed Dec  6 19:42:46 2006
> @@ -70,16 +70,9 @@
>        struct buf *bp;
>        int vfslocked;
> 
> -       if (bip->bio_error) {
> -               printf("g_vfs_done():");
> -               g_print_bio(bip);
> -               printf("error = %d\n", bip->bio_error);
> -       }
>        bp = bip->bio_caller2;
>        bp->b_error = bip->bio_error;
>        bp->b_ioflags = bip->bio_flags;
> -       if (bip->bio_error)
> -               bp->b_ioflags |= BIO_ERROR;
>        bp->b_resid = bp->b_bcount - bip->bio_completed;
>        g_destroy_bio(bip);
>        vfslocked = VFS_LOCK_GIANT(((struct mount *)NULL));
> 


So what happens when you have a regular drive fail then?  Or yank a SATA 
or other drive out from under the OS?

This patch seems awfully dangerous to me..

Eric