From owner-cvs-all@FreeBSD.ORG Mon Jun 18 08:25:23 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6441316A400; Mon, 18 Jun 2007 08:25:23 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 3BE2613C457; Mon, 18 Jun 2007 08:25:23 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 4DB5B1A4D81; Mon, 18 Jun 2007 01:24:39 -0700 (PDT) Date: Mon, 18 Jun 2007 01:24:39 -0700 From: Alfred Perlstein To: Tim Kientzle Message-ID: <20070618082439.GD96936@elvis.mu.org> References: <200706180036.l5I0asac023540@repoman.freebsd.org> <4675DFC8.8060108@freebsd.org> <46760F7A.8020209@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46760F7A.8020209@freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Colin Percival Subject: Re: cvs commit: src/lib/libarchive archive_read_open_fd.c archive_read_open_filename.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2007 08:25:23 -0000 * Tim Kientzle [070617 21:52] wrote: > > Note that the second call returns a new file position > that's exactly 0x2f800 bytes beyond the former file > position, even though nothing has actually happened. > > I think any of the following would be reasonable behaviors: > * lseek() could return ESPIPE ("illegal seek") > * lseek() could return an unchanged file offset > (indicating that the file position was unchanged by > the attempted seek). > * lseek() could return ENOTSUP ("unsupported operation") > As I said though, I just don't know that code well > enough to propose a fix. ENOTSUP seems to be the most "correct", although I sort of see it being the equivelant of dispaching a sign saying "bump" along the highway without actually fixing said bump. :( -- - Alfred Perlstein