From owner-freebsd-ports  Tue Jan 20 05:07:36 1998
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id FAA04123
          for freebsd-ports-outgoing; Tue, 20 Jan 1998 05:07:36 -0800 (PST)
          (envelope-from owner-freebsd-ports@FreeBSD.ORG)
Received: from lsd.relcom.eu.net (ache@lsd.relcom.eu.net [193.124.23.23])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA04118;
          Tue, 20 Jan 1998 05:07:31 -0800 (PST)
          (envelope-from ache@lsd.relcom.eu.net)
Received: (from ache@localhost)
	by lsd.relcom.eu.net (8.8.8/8.8.8) id QAA24902;
	Tue, 20 Jan 1998 16:07:24 +0300 (MSK)
	(envelope-from ache)
Date: Tue, 20 Jan 1998 16:07:21 +0300 (MSK)
From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
X-Sender: ache@lsd.relcom.eu.net
To: Satoshi Asami <asami@cs.berkeley.edu>
cc: peter@netplex.com.au, perhaps@yes.no, gpalmer@FreeBSD.ORG,
        ports@FreeBSD.ORG, committers@FreeBSD.ORG
Subject: Re: amanda port, empty PATCH_STRIP= lines causes trouble
In-Reply-To: <Pine.BSF.3.96.980120153843.24732A-100000@lsd.relcom.eu.net>
Message-ID: <Pine.BSF.3.96.980120160227.24851A-100000@lsd.relcom.eu.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=KOI8-R
Content-Transfer-Encoding: 8BIT
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Just and addition to previous...

On Tue, 20 Jan 1998, Андрей Чернов wrote:

> Index: src/Makefile
> *** 1997NNN/src/Makefile
> *** 1997XXX/src/Makefile

I mean "---" instead of "***" in second line, of course.

> > Can you make a filter like that work reliably?  And are we going to
> > call it "patch"?
> 
> I already think about alternate /usr/bin/broken_patch especially for
> ports system, but even in this case it should be NOT be called for 3-rd
> party "distributed" patches, standard /usr/bin/patch should be called
> in such cases.

Alternate question will be: is it worth? Right now we have only 3 patches
with incorrect Index: vs *** in the ports tree, the are:

modula-3-socks, virtualpager, rdist6

maybe better just convert them and not make any additional action?
If somebody send us new port with broken CVS diff, it simple not
applied by patch system, so can't sneak in the ports tree unmodified.

-- 
Andrey A. Chernov
<ache@nietzsche.net>
http://www.nagual.pp.ru/~ache/