From owner-freebsd-current@FreeBSD.ORG Mon Apr 26 23:24:06 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7329216A4CF; Mon, 26 Apr 2004 23:24:06 -0700 (PDT) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id A01BA43D49; Mon, 26 Apr 2004 23:24:03 -0700 (PDT) (envelope-from sos@DeepCore.dk) Received: from DeepCore.dk (sos.deepcore.dk [194.192.25.130]) by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i3R6NuEP041712; Tue, 27 Apr 2004 08:24:01 +0200 (CEST) (envelope-from sos@DeepCore.dk) Message-ID: <408DFC7C.4010503@DeepCore.dk> Date: Tue, 27 Apr 2004 08:23:56 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= User-Agent: Mozilla Thunderbird 0.5 (X11/20040329) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andre Guibert de Bruet References: <20040427020355.Q21538@alpha.siliconlandmark.com> In-Reply-To: <20040427020355.Q21538@alpha.siliconlandmark.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-mail-scanned: by DeepCore Virus & Spam killer v1.4 cc: current@FreeBSD.ORG cc: sos@FreeBSD.ORG Subject: Re: Recent ata-pci.c change breaks a7m266-d system (Was: Re:"setrootbyname failed" leads to "ffs_mountroot: can't find rootvp" on boot.) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2004 06:24:06 -0000 Andre Guibert de Bruet wrote: > Okay, I found the commit that caused this problem. The following commit > breaks my SMP desktop: > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/ata/ata-pci.c.diff?r1=1.80&r2=1.81&f=h > > Reverting the one line fixes things. I've attached a trivial one-line > patch that reverts the change. Could this be committed? Actually it takes a bit more than that to get it right in all situations. I'm close to having this solved and will commit asap... -- -Søren